Skip to content

Fix unit test #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Fix unit test #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e4f777
Point release
coatless Feb 6, 2020
27125c7
Update release notes
coatless Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: errorist
Title: Automatically Search Errors or Warnings
Version: 0.1.0
Version: 0.0.3
Authors@R: c(
person("James", "Balamuta",
email = "balamut2@illinois.edu",
Expand Down
7 changes: 4 additions & 3 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# errorist 0.1.0
# errorist 0.0.3

## Features
## Bug Fix

- TBA
- Address an erroneous unit test that was comparing functions within namespaces
instead of environments.

# errorist 0.0.2

Expand Down
10 changes: 6 additions & 4 deletions cran-comments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
## Test environments

- local OS X install, R 3.5.2
- ubuntu 14.04 (on travis-ci), R 3.5.2
- local OS X install, R 3.6.2
- ubuntu 14.04 (on travis-ci), R 3.6.2
- win-builder (devel and release)

## R CMD check results

0 errors | 0 warnings | 0 note

- This release is meant to resolve an import issue on the CRAN checks page.
- This release is meant to resolve an issue with one of the unit tests
on the CRAN checks page.
-

## Reverse dependencies

This is a new release, so there are no reverse dependencies.
There are no reverse dependencies.
8 changes: 2 additions & 6 deletions tests/testthat/test-handlers.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,11 @@ test_that("Check Output from Functions", {
# Retrieve the function
test_error_function = test_error_call[[1]]

# Retrieve function name space
# See: https://stackoverflow.com/a/6433626/1345455
get_function_namespace = function(func) { getNamespaceName(environment(func)) }

expect_true(is.function(options_default_function),
"Verify the default error handler is a function.")

expect_true(get_function_namespace(test_error_function) ==
get_function_namespace(options_default_function) ,
expect_true(identical(environment(test_error_function),
environment(options_default_function)),
"Verify that test function call matches the default function's environment")

expect_equal(test_error_function("toad"), options_default_function("toad"),
Expand Down