Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up(possibly fatal) check for Rcpp and RcppArmadillo now opt-in (closes #19) #21
Conversation
|
See #19 for discussion and context. |
|
@eddelbuettel I think we can just get rid of header check instead of providing a define. The logic here was present if we needed extra defines. However, Ensmallen is automatically using variables set inside RcppArmadillo (e.g. redirect of STDOUT/STDERR and RNG). |
|
Either way it needs fixing. One way would be to merge PR and then refine, another to mod the PR then merge. |
|
Done. Closes out #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.