Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix formatting when constructing NEWS.md in the upstream update GitHub Action #33
Conversation
Address space issue for NEWS entry bullets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
When #30 was added, we couldn't easily test the workflow as it needed to be merged prior to being registered as an action. With the first run now completed in #31, the majority of the action worked as intended. Though, there were issues with formatting the news entry.
8cac8a8
I've manually corrected it for the first time within #31. With this fix, we shouldn't see a similar formatting error appear. As an added bonus, I think I've added the option to manually trigger the action via
workflow_dispatch.As a side note, the Linux action change in #32 also was changed here to only retain the
develbuild under Linux as it failed randomly when merged into master withreleasealso active.