New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pulldown-cmark to 0.0.14 #212

Merged
merged 2 commits into from Apr 20, 2017

Conversation

Projects
None yet
2 participants
@iovxw
Copy link
Contributor

iovxw commented Apr 20, 2017

The old test failed because it was wrong

the old test:
old_test

new test:
new_test

iovxw added some commits Apr 20, 2017

@epage

This comment has been minimized.

Copy link
Member

epage commented Apr 20, 2017

The travis failure is because of clippy failures. I'm assuming these are from a new version of clippy since you didn't change that code. The reason for the inconsistency with appveyor is it appears we don't run clippy on appveyor.

@epage

This comment has been minimized.

Copy link
Member

epage commented Apr 20, 2017

Started on #213 to unblock you.

@epage

This comment has been minimized.

Copy link
Member

epage commented Apr 20, 2017

Drat, kicking travis off again didn't try to run your patch against the latest trunk. Barring a dummy commit on your part, I'm not sure how to get it to re-run. I'm pretty sure all the failures are addressed and unrelated to your change, so I'm going to go ahead and submit this.

Thank you for taking the time to upgrade this. I'm sorry for our CI being a hassle.

@epage epage merged commit 5c41f85 into cobalt-org:master Apr 20, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment