Upgrade pulldown-cmark to 0.0.14 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis failure is because of clippy failures. I'm assuming these are from a new version of clippy since you didn't change that code. The reason for the inconsistency with appveyor is it appears we don't run clippy on appveyor. |
|
Started on #213 to unblock you. |
|
Drat, kicking travis off again didn't try to run your patch against the latest trunk. Barring a dummy commit on your part, I'm not sure how to get it to re-run. I'm pretty sure all the failures are addressed and unrelated to your change, so I'm going to go ahead and submit this. Thank you for taking the time to upgrade this. I'm sorry for our CI being a hassle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old test failed because it was wrong
the old test:
new test:
