feat: CR safeguards, throttle CRD creation, adding limit#884
Merged
Conversation
mblos
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer and
umswmayj
as code owners
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughAdds configurable slot-creation pacing and per-commitment slot limits to reservation creation, refactors flavor-selection, integrates a monitor for slot-limit rejections, exposes Helm values, and extends tests for the new behaviors. ChangesReservation Slot Creation Throttling and Limits
Sequence DiagramsequenceDiagram
participant CommittedResourceController
participant ReservationManager
participant API_Server
participant CRControllerMonitor
CommittedResourceController->>ReservationManager: ApplyCommitmentState(ctx, cr)
ReservationManager->>ReservationManager: countNewSlots(deltaMemoryBytes)
alt newSlots > MaxSlots
ReservationManager-->>CommittedResourceController: SlotLimitExceededError
CommittedResourceController->>CRControllerMonitor: RecordSlotLimitRejection(flavorGroup, az)
else within limit
loop create slots
ReservationManager->>API_Server: Create Reservation CRD (flavor, memory, cpu)
API_Server-->>ReservationManager: Created
alt SlotCreationDelay > 0 and more slots
ReservationManager->>ReservationManager: wait SlotCreationDelay or ctx.Done()
end
end
ReservationManager-->>CommittedResourceController: success
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Test Coverage ReportTest Coverage 📊: 69.7% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two safeguards to prevent a burst of Reservation CRD creates from overwhelming the scheduler on large commitments.