check_setup method in Cli.py class BootCLI, should print more detailed exception info #148

Closed
hackiechain opened this Issue Apr 23, 2012 · 2 comments

Comments

Projects
None yet
3 participants

I was confused by this kind of print out. What is going wrong.Is it the cobblerd stoped?Or, the appache server is down?I think user should have known more detailed exception infomation.

[root@localhost ~]# cobbler
httpd does not appear to be running and proxying cobbler

I made some changes in source code.

check_setup method in Cli.py class BootCLI
line 175
s = xmlrpclib.Server(self.url_cobbler_xmlrpc)
try:
s.ping()
except:
print >> sys.stderr, "cobblerd does not appear to be running/accessible"
sys.exit(411)

The better print out.
s = xmlrpclib.Server(self.url_cobbler_xmlrpc)
try:
s.ping()
except Exception,e:
print >> sys.stderr, "cobblerd does not appear to be running/accessible, Exception: "%(repr(e))
sys.exit(411)

Owner

jimi-c commented May 24, 2012

I'm trying to move away from printing stack dumps for errors, but I'll look into printing something more descriptive. This error is a bit vague because it really could be either httpd or cobblerd having issues, so the error should point the user in that direction and tell them to check both. Might even be worthwhile noting that dropping SELinux to permissive or to look for AVCs in the logs in case SELinux is the issue.

@ghost ghost assigned jimi-c May 24, 2012

Owner

jmaas commented Jun 12, 2014

Error handling should indeed be improved all over.
For now i implemented the suggested fix.

jmaas added a commit that referenced this issue Jun 12, 2014

@jmaas jmaas closed this Jun 12, 2014

jmaas added a commit that referenced this issue Jun 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment