Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add httpboot config #2295

Merged
merged 1 commit into from May 13, 2020
Merged

add httpboot config #2295

merged 1 commit into from May 13, 2020

Conversation

thiller2018
Copy link
Contributor

#2102 add httpboot to cobbler

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #2295 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2295   +/-   ##
======================================
  Coverage    1.69%   1.69%           
======================================
  Files          91      91           
  Lines       12626   12626           
======================================
  Hits          214     214           
  Misses      12412   12412

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f91365d...dc85ed5. Read the comment docs.

@SchoolGuy SchoolGuy linked an issue Mar 3, 2020 that may be closed by this pull request
@SchoolGuy SchoolGuy added this to Pull Requests in Backlog via automation Mar 3, 2020
@SchoolGuy SchoolGuy requested a review from watologo1 March 3, 2020 14:55
@SchoolGuy
Copy link
Member

@watologo1 Review reminder.

@SchoolGuy
Copy link
Member

@watologo1 Again! Review reminder.

@SchoolGuy SchoolGuy requested a review from brejoc May 11, 2020 19:51
Copy link
Contributor

@watologo1 watologo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that it took that long.
I wasn't sure whether it is better or even needed to duplicate data in www server directory.

Anyway, this is a nice, tiny change to be able to play with httpboot. So please go ahead and merge.

Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also from my side uncritical to add.

@SchoolGuy SchoolGuy merged commit b6da350 into cobbler:master May 13, 2020
Backlog automation moved this from Pull Requests to Done May 13, 2020
@hbokh
Copy link
Contributor

hbokh commented May 14, 2020

Sorry for crashing into a late party...
On my two Cobbler 3 installations (Debian & CentOS) I don't have anything Cobbler related in /srv/ anymore.
Instead, grub & images are in /var/lib/tftpboot/grub & /var/lib/tftpboot/images.
Is there something missing or did I miss something myself?

@SchoolGuy
Copy link
Member

@hbokh You make a totally valid point here. On Debian based systems the folders are different. Thus we need to replace the path depending on the distro. I will create an issue for that. As a quick fix you can of course adjust the paths manually in the config files.

@hbokh
Copy link
Contributor

hbokh commented May 14, 2020

| On Debian based systems the folders are different.

FYI The paths are also missing in CentOS 7.
Only SUSE is pointing to /srv/tftpboot in cobbler.spec.

@SchoolGuy SchoolGuy added this to the v3.1.2 milestone May 27, 2020
@SchoolGuy SchoolGuy removed this from Done in Backlog Oct 24, 2020
@SchoolGuy SchoolGuy added this to Pull Requests in V3.1.2 via automation Jun 29, 2021
@SchoolGuy SchoolGuy moved this from Pull Requests to Done in V3.1.2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

support for httpboot?
4 participants