Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Settings to the API #2664

Merged
merged 1 commit into from Jun 9, 2021
Merged

Move Settings to the API #2664

merged 1 commit into from Jun 9, 2021

Conversation

SchoolGuy
Copy link
Member

Splitout of #2433

This PR aims to move the Settings into the API.

@SchoolGuy SchoolGuy added this to the v3.3.0 milestone Jun 9, 2021
@SchoolGuy SchoolGuy requested a review from nodeg June 9, 2021 11:15
@SchoolGuy SchoolGuy added this to Pull Requests in Backlog via automation Jun 9, 2021
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #2664 (3756281) into master (86fad29) will increase coverage by 0.01%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2664      +/-   ##
==========================================
+ Coverage   33.20%   33.22%   +0.01%     
==========================================
  Files          85       85              
  Lines       12395    12398       +3     
==========================================
+ Hits         4116     4119       +3     
  Misses       8279     8279              
Impacted Files Coverage Δ
cobbler/cobbler_collections/manager.py 70.29% <50.00%> (ø)
cobbler/api.py 42.54% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86fad29...3756281. Read the comment docs.

Copy link
Member

@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nodeg nodeg merged commit 3403c3b into master Jun 9, 2021
Backlog automation moved this from Pull Requests to Done Jun 9, 2021
@SchoolGuy SchoolGuy deleted the move-settings-to-api branch June 9, 2021 12:59
@SchoolGuy SchoolGuy removed this from Done in Backlog Jun 29, 2021
@SchoolGuy SchoolGuy added this to Pull Requests in V3.3.0 via automation Jun 29, 2021
@SchoolGuy SchoolGuy moved this from Pull Requests to Done in V3.3.0 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants