Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upimplement getbalance rpc call #26
Conversation
thomaseizinger
requested changes
Sep 26, 2018
|
Thank you for the contribution! We want to represent the actual JSON-RPC API as close as possible. This includes exposing all the parameters of function calls. |
src/bitcoincore.rs
Outdated
| @@ -164,6 +164,10 @@ impl BitcoinRpcApi for BitcoinCoreClient { | |||
| )) | |||
| } | |||
|
|
|||
| fn get_balance(&self) -> Result<Result<f32, RpcError>, HTTPError> { | |||
This comment has been minimized.
This comment has been minimized.
thomaseizinger
Sep 26, 2018
Member
According to the API here: https://bitcoin.org/en/developer-reference#getbalance, getbalance has 3 parameters:
- an account (although this one is deprecated, I think we should still add it for now) it is an optional parameter, so we should probably accept an
Option<String>and default to*as described in the docs if it is missing. - minimum number of confirmations
- whether to include watch-only addresses
Please add these 3 parameters to the method.
This comment has been minimized.
This comment has been minimized.
|
Please resolve the merge conflicts. In addition could you also please squash those changes together into one commit? |
D4nte
added
the
work-in-progress
label
Dec 10, 2018
bonomat
added this to the Sprint 4 🎄🎅🏿 milestone
Dec 20, 2018
D4nte
removed this from the Sprint 4 🎄🎅🏿 milestone
Jan 8, 2019
D4nte
added
sprint-backlog
and removed
work-in-progress
labels
Jan 8, 2019
D4nte
added this to the Sprint 5 📜🔓 milestone
Jan 9, 2019
This comment has been minimized.
This comment has been minimized.
|
Hi @evgeniy-scherbina, I'll take over your change due to lack of activity. |
D4nte
referenced this pull request
Jan 10, 2019
Merged
Upgrade to bitcoind 0.17.0 and implement getbalance call #45
D4nte
self-assigned this
Jan 10, 2019
This comment has been minimized.
This comment has been minimized.
|
Replaced with #45 |
D4nte
closed this
Jan 10, 2019
wafflebot
bot
removed
the
sprint-backlog
label
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
evgeniy-scherbina commentedSep 26, 2018
No description provided.