Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_element_visible missing from API docs? #712

Closed
tony opened this issue Sep 11, 2019 · 5 comments
Closed

is_element_visible missing from API docs? #712

tony opened this issue Sep 11, 2019 · 5 comments

Comments

@tony
Copy link

@tony tony commented Sep 11, 2019

is_element_visible is a very helpful function, but haven't figured out why / what would be the clearest way to make it available in the docs (Should we make all Window available?)

@andrewsmedina

This comment has been minimized.

Copy link
Member

@andrewsmedina andrewsmedina commented Sep 12, 2019

A good place for the docs about this method is the matchers page: https://github.com/cobrateam/splinter/blob/master/docs/matchers.rst

@andrewsmedina andrewsmedina added this to the 1.0 milestone Sep 12, 2019
@sukhbeersingh

This comment has been minimized.

Copy link
Contributor

@sukhbeersingh sukhbeersingh commented Sep 29, 2019

Hi , I would like to work on this issue.

@andrewsmedina

This comment has been minimized.

Copy link
Member

@andrewsmedina andrewsmedina commented Sep 29, 2019

@sukhbeersingh fell free to work on it. If you need help let us know.

@sukhbeersingh

This comment has been minimized.

Copy link
Contributor

@sukhbeersingh sukhbeersingh commented Oct 6, 2019

Is the intent to just include the said function in the matchers page? Or is it to make a new page (windows.rst) and incorporate this in there?

@andrewsmedina

This comment has been minimized.

Copy link
Member

@andrewsmedina andrewsmedina commented Dec 12, 2019

closed by #723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.