Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected programming language classifiers to exclude Python 3.0, 3.1 and 3.2 #305

Merged
merged 1 commit into from Apr 8, 2014
Merged

Corrected programming language classifiers to exclude Python 3.0, 3.1 and 3.2 #305

merged 1 commit into from Apr 8, 2014

Conversation

fgimian
Copy link
Contributor

@fgimian fgimian commented Apr 5, 2014

Hello there,

This is a tiny pull request to ensure that the correct versions of Python are listed in the classifiers section of setup.py and PyPi. The package is currently being tested and is compatible with Python 2.7 and 3.3.

I have also tested it with a very minor change (use unittest2) on Python 2.6 and can confirm that it is also Python 2.6 compatible. I'll be submitting a pull request soon to correct the tests for Python 2.6, but the library itself is fully Python 2.6 compatible already.

Cheers
Fotis

@andrewsmedina
Copy link
Member

@fgimian what about 3.4?

@fgimian
Copy link
Contributor Author

fgimian commented Apr 8, 2014

Good point. Let me test it out with Python 3.4 and I'll get back to you 😄

Cheers
Fotis

@fgimian
Copy link
Contributor Author

fgimian commented Apr 8, 2014

@andrewsmedina After further testing, I think that it is safe to add Python 3.4 to the classifiers list. I have updated my pull request with this addition.

Unfortunately, we can't yet add it to .travis.yml since Travis CI doesn't yet support Python 3.4 (please see issue travis-ci/travis-ci#1989 for further information).

Cheers
Fotis

@andrewsmedina
Copy link
Member

@fgimian thank you!

andrewsmedina added a commit that referenced this pull request Apr 8, 2014
Corrected programming language classifiers to exclude Python 3.0, 3.1 and 3.2
@andrewsmedina andrewsmedina merged commit 4f20b75 into cobrateam:master Apr 8, 2014
@fgimian fgimian deleted the correct_classifiers branch April 8, 2014 13:13
@fgimian
Copy link
Contributor Author

fgimian commented Apr 8, 2014

My pleasure, thanks for the merge! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants