Enable timeout setting for Firefox webdriver #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there's no straightforward way to specify the timeout for the Firefox webdriver. Selenium's default value (30) is too short for low-performance settings, so it would be desirable to not only have a larger timeout window (this PR sets it to 90) as well as letting the user define this when instantiating the webdriver.
|
Hey, just noticed this is still open. I tried looking through the Travis build logs to understand why it failed but I can't make much sense of the logs. Can someone point me the way to fix whatever problem this PR caused? |
|
@rlafuente thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's no straightforward way to specify the timeout for the Firefox webdriver.
Selenium's default value (30) is too short for low-performance settings, so it would be desirable to not only have a larger timeout window (this PR sets it to 90) as well as letting the user define this when instantiating the webdriver.