Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Re-add link_spec JS function #12

Merged
merged 1 commit into from
Sep 1, 2015
Merged

Conversation

fnagel
Copy link
Contributor

@fnagel fnagel commented Aug 28, 2015

Needed for TYPO3 7.4 to fix RTE link browser.

Fixes #11

Needed for TYPO3 7.4 to fix RTE link browser.

Fixes cobwebch#11
@fsuter
Copy link
Contributor

fsuter commented Aug 31, 2015

I tried your patch, but I stumble on other issues. When clicking on the name of news folder (for example), I get a JS error complaining that function "insertElement" is undefined. And if I try to click on the expand arrow on the left side or the "drill in" arrow on the right side, I get the full BE loaded in the browse link popup. Did you not observe something similar? I'm actually not strictly on 7.4, but on 7.5-dev.

I'm willing to merge your pull request blindly, but it seems like more compatibility issues are ahead. I must admit that I'm getting rather desperate. I hope that this effort makes it: https://forge.typo3.org/issues/46140

@fnagel
Copy link
Contributor Author

fnagel commented Aug 31, 2015

Just tested this again in 7.4.0 and it seems everything works fine. No JS errors, no wrong reloading. Using latest Chrome on Win8.1.

Sounds like you're right and something bad will happen in 7.5.

fsuter added a commit that referenced this pull request Sep 1, 2015
[BUGFIX] Re-add link_spec JS function
@fsuter fsuter merged commit ad1024a into cobwebch:master Sep 1, 2015
@fsuter
Copy link
Contributor

fsuter commented Sep 1, 2015

Thanks for your feedback. So I went ahead and merged your change. Let's see if we can manage to keep that patient's heart beating :-\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS error in element browser (TYPO3 7.4)
2 participants