Use ChangeLog date instead of build date #121
Conversation
|
On Wed, 15 Nov 2017, Bernhard M. Wiedemann wrote:
in order to make builds from release tarballs reproducible.
See https://reproducible-builds.org/ for why this is good.
Also use date -u to not depend on the packager's timezone.
Note: there is one remaining issue likely from pycaml embedding a
/tmp/camlprimXXXXXX.c random string in spatch debug_str section but that can
be solved independently of this one.
Hello,
Thanks for the patch. Please add a Signed-off-by:
Is this presupposing that every change is accompanied by an update in the
changelog? Currently that is not the case. The changelog mostly only
contains changes that are significant enough that users might notice.
julia
…
____________________________________________________________________________
You can view, comment on, or merge this pull request online at:
#121
Commit Summary
* Use ChangeLog date instead of build date
File Changes
* M setup/cocci.m4 (4)
Patch Links:
* https://github.com/coccinelle/coccinelle/pull/121.patch
* https://github.com/coccinelle/coccinelle/pull/121.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the
thread.[AAesmtCG39HNDSs46g6_D9joq0Yj5b-7ks5s2maWgaJpZM4QeX6O.gif]
|
in order to make builds from release tarballs reproducible. See https://reproducible-builds.org/ for why this is good. Also use date -u to not depend on the packager's timezone. Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
|
added Signed-off-by
This is mostly about builds from the release tarballs (because there is a separate code path if a .git dir exists) and it seems reasonable to assume that no release is done without relevant changes. |
|
I became also curious on how the shown software development aspect will evolve further. |
|
Thanks for that link. I did not know that you were interested in that topic for that long. |
|
Is there anything I can help to get this simple change merged? |
|
On Tue, 19 Dec 2017, Bernhard M. Wiedemann wrote:
Is there anything I can help to get this simple change merged?
Could you send it by email?
thanks,
julia
|
How do you think about to use the interface “pull request” directly? |
|
This change is also available as a patch at https://github.com/coccinelle/coccinelle/pull/121.patch |
|
On Tue, 19 Dec 2017, Bernhard M. Wiedemann wrote:
This change is also available as a patch at
https://github.com/coccinelle/coccinelle/pull/121.patch
to be applied via git am if you prefer that.
Thanks for the pointer. I looked for such a thing but could not find it.
julia
…
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the
thread.[AAesmkdZc6o5Fc0IVhcnORJRT7QqbOn3ks5tCK24gaJpZM4QeX6O.gif]
|
|
On Tue, 19 Dec 2017, Bernhard M. Wiedemann wrote:
This change is also available as a patch at
https://github.com/coccinelle/coccinelle/pull/121.patch
to be applied via git am if you prefer that.
I'm still not sure why you want the date of the changelog. Why not the
date of the most recent commit? Requiring the date of the changelog would
seem to require a specific policy for adding changelog entries.
julia
…
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the
thread.[AAesmkdZc6o5Fc0IVhcnORJRT7QqbOn3ks5tCK24gaJpZM4QeX6O.gif]
|
How would you identify the commit which should be the last one for a specific software release? |
|
On Wed, 20 Dec 2017, Markus Elfring wrote:
Why not the date of the most recent commit?
How would you identify the commit which should be the last one for a
specific software release?
The appropriate git log command? Maybe git log -n1 --pretty=format:%cD
julia
…
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the
thread.[AAesmjV3EVzFq8Lbd_bjW_5YZXE_J8bTks5tCP9xgaJpZM4QeX6O.gif]
|
|
Would you like to distinguish building of the software ever according to a commit sequence or an other release identifier? |
|
On Wed, 20 Dec 2017, Markus Elfring wrote:
Would you like to distinguish building of the software ever according to a
commit sequence or an other release identifier?
I don't think we want to make a release based on anything other than
the latest version, if that is the question, And I don't see how taking
the date of the changelog resolves this issue.
julia
…
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the
thread.[AAesmql61vEz-UNaa_gnIFKFrXaZ5KU9ks5tCQjRgaJpZM4QeX6O.gif]
|
Such a command works only if you have got read access to a git repository. If you would like to support other software distribution formats, you will need to reconsider the situation a bit more. |
|
I guess, you could also do both: first look for a .git dir and use the last commit date |
Use ChangeLog date instead of build date
in order to make builds from release tarballs reproducible.
See https://reproducible-builds.org/ for why this is good.
Also use date -u to not depend on the packager's timezone.
Note: there is one remaining issue likely from pycaml embedding a /tmp/camlprimXXXXXX.c random string in spatch debug_str section but that can be solved independently of this one.