Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple dashboard redesign #1726

Closed
stefwalter opened this issue Jan 26, 2015 · 9 comments

Comments

Projects
None yet
3 participants
@stefwalter
Copy link
Contributor

commented Jan 26, 2015

Cockpit top level navigation needs some tweaks.

  • Support multiple dashboards

Some secondary goals:

  • First time accessing cockpit, arrive at server summary, not a dashboard
  • Have a top level navbar across all parts of Cockpit

@stefwalter stefwalter self-assigned this Jan 26, 2015

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Jan 26, 2015

Basic design proposal:

navigation

navigation-server

@stefwalter stefwalter removed the needsdesign label Jan 26, 2015

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Jan 26, 2015

The set of dashboard top navbar items moves to the right when you go into a machine. It moves back to the left, when you go to one of the dashboards. It doesn't move as long as your mouse is over the navbar.

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Jan 26, 2015

Blocks on #1544

@andreasn

This comment has been minimized.

Copy link
Contributor

commented Jan 27, 2015

I am starting to come to peace with this idea bit by bit :)
So the Journal would be in two places? Is one a single-machine journal and one an aggregated journal?
Does a machine view stay on, say Storage if I switch to another machine and switch back? (Im trying to figure out how much work the use case where you set up a network disk on one machine and then go to another machine and mount it there).

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Jan 27, 2015

So the Journal would be in two places? Is one a single-machine journal and one an aggregated journal?

Nope. sorry for that in the mockups. It shouldn't be in the sidebar.

Does a machine view stay on, say Storage if I switch to another machine and switch back? (Im trying to figure out how much work the use case where you set up a network disk on one machine and then go to another machine and mount it there).

That could be decided. The PatternFly host switcher pattern does stay on Storage when you switch. However this is a separate issue, and orthogonal to this redesign. Whatever we choose here, it's easy to use multiple browser tabs or windows to perform two actions on two machines at once. You should be able to middle click on things to open stuff in new tabs.

@andreasn

This comment has been minimized.

Copy link
Contributor

commented Jan 27, 2015

Nope. sorry for that in the mockups. It shouldn't be in the sidebar.

Sounds good

However this is a separate issue, and orthogonal to this redesign

Mostly trying to figure that out since it could regress compared to our current ui.

@sub-mod

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2015

@stefwalter what is the update on this ? Does this effect us ?

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2015

It needs to land before we finish the proof of concept, and demo it, so that the Kubernetes stuff can move out of the 'Tools' menu.

But other than that, it does not affect our implementation of the kubernetes dashboard.

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2015

After implementing it, the following issues need tweaking:

  • After going to a dashboard, it should be easier to get back to servers than going through the Machines dashboard
  • The top bar is very empty in the default configuration.

Will iterate to fix these issues.

stefwalter added a commit to stefwalter/cockpit that referenced this issue Feb 27, 2015

shell: Implement new multiple dashboards navigation
This implements the multiple dashboards navigation that we've
been discussing.

I wish it was easier to split this up into multiple commits, but
it's all pretty intertwined.

The new index.html and index.js are the default page that's loaded.
Everything in shell.html is loaded as a framed component, along with
the things that are already components. We remove a bunch of code
related to machines in the shell javascript code.

Fixes cockpit-project#1726

stefwalter added a commit to stefwalter/cockpit that referenced this issue Feb 27, 2015

shell: Implement new multiple dashboards navigation
This implements the multiple dashboards navigation that we've
been discussing.

I wish it was easier to split this up into multiple commits, but
it's all pretty intertwined.

The new index.html and index.js are the default page that's loaded.
Everything in shell.html is loaded as a framed component, along with
the things that are already components. We remove a bunch of code
related to machines in the shell javascript code.

Fixes cockpit-project#1726

stefwalter added a commit to stefwalter/cockpit that referenced this issue Feb 27, 2015

shell: Implement new multiple dashboards navigation
This implements the multiple dashboards navigation that we've
been discussing.

I wish it was easier to split this up into multiple commits, but
it's all pretty intertwined.

The new index.html and index.js are the default page that's loaded.
Everything in shell.html is loaded as a framed component, along with
the things that are already components. We remove a bunch of code
related to machines in the shell javascript code.

Fixes cockpit-project#1726

stefwalter added a commit to stefwalter/cockpit that referenced this issue Mar 3, 2015

test: Fix tests for new navigation
This includes changes to account for dashboards and everything
being in a frame.

Fixes cockpit-project#1726
Closes cockpit-project#1861

stefwalter added a commit to stefwalter/cockpit that referenced this issue Mar 3, 2015

test: Fix tests for new navigation
This includes changes to account for dashboards and everything
being in a frame.

Fixes cockpit-project#1726
Closes cockpit-project#1861

stefwalter added a commit to stefwalter/cockpit that referenced this issue Mar 3, 2015

test: Fix tests for new navigation
This includes changes to account for dashboards and everything
being in a frame.

Fixes cockpit-project#1726
Closes cockpit-project#1861

stefwalter added a commit to stefwalter/cockpit that referenced this issue Mar 3, 2015

test: Fix tests for new navigation
This includes changes to account for dashboards and everything
being in a frame.

Fixes cockpit-project#1726
Closes cockpit-project#1861

stefwalter added a commit to stefwalter/cockpit that referenced this issue Mar 3, 2015

test: Fix tests for new navigation
This includes changes to account for dashboards and everything
being in a frame.

Fixes cockpit-project#1726
Closes cockpit-project#1861

@stefwalter stefwalter closed this in 22eecf9 Mar 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.