Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all remaining translatable strings #1983

Closed
stefwalter opened this issue Mar 23, 2015 · 0 comments
Closed

Mark all remaining translatable strings #1983

stefwalter opened this issue Mar 23, 2015 · 0 comments
Labels
good-first-issue Appropriate for new contributors

Comments

@stefwalter
Copy link
Contributor

We should mark all remaining translatable strings. In particular:

  • Strings in code should be marked with _("String")
  • Strings in HTML should be marked with the attribute translatable="yes" in their surrounding tag.
  • Numbered translatable strings will need to use cockpit.ngettext("Singular", "Plural", count), likely wrapped in a cockpit.format(...) call.

This will require a bit of refactoring in places:

  • Where we don't have a translatable string alone in a tag, it probably needs to be put in its own tag, and then checked that this doesn't break things.
  • In cases where we use Mustache we need to add translatable="yes" attributes, and then run cockpit.translate on the resulting element.
  • In cases where we don't yet call cockpit.translate() on a page, we need to do that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Appropriate for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant