Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove last redundant tabIndex attributes #15326

Merged
merged 2 commits into from Feb 12, 2021
Merged

Remove last redundant tabIndex attributes #15326

merged 2 commits into from Feb 12, 2021

Conversation

KKoukiou
Copy link
Contributor

Fixes #6057

@KKoukiou KKoukiou mentioned this pull request Feb 12, 2021
Closed
@KKoukiou KKoukiou changed the title Remove last redundant tabIndex attrbutes Remove last redundant tabIndex attributes Feb 12, 2021
martinpitt
martinpitt approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! I thought the progresses had to be tab-able to get a proper screen reader output, but indeed that was bogus -- any other non-tabable element like labels needs to be covered by the screen reader anyway.

@KKoukiou KKoukiou merged commit dd20bce into cockpit-project:master Feb 12, 2021
@KKoukiou KKoukiou deleted the tabIndex-remove branch February 12, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpitt martinpitt martinpitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tabbing order is not optimal: remove tabindex to use built-in browser order
2 participants
@KKoukiou @martinpitt