docker: Allow deleting containers from lists #1724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stefwalter yeah, that sounds like a good idea! |
|
Design decision changed, will open a new PR that implements the new design decision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the 2nd design even though adding another column changed quite a few things layout wise. I don't know why the buttons were absolutely positioned before changing that made this easier but it's possible that was needed for something and this breaks it. I also added the same styles to the container list on the images page. That had a very different style, i'm not sure if it was missed or intentional. One other thing to note, deleting a running container will error, we could force it if everything thinks that isn't ok.