Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Allow deleting containers from lists #1724

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@petervo
Copy link
Contributor

commented Jan 24, 2015

I implemented the 2nd design even though adding another column changed quite a few things layout wise. I don't know why the buttons were absolutely positioned before changing that made this easier but it's possible that was needed for something and this breaks it. I also added the same styles to the container list on the images page. That had a very different style, i'm not sure if it was missed or intentional. One other thing to note, deleting a running container will error, we could force it if everything thinks that isn't ok.

@stefwalter

This comment has been minimized.

Copy link
Contributor

commented Jan 26, 2015

@andreasn @petervo Should we disable the multi-delete [x] buttons for running containers, and have a tooltip explaining why they can't be deleted?

@andreasn

This comment has been minimized.

Copy link
Contributor

commented Jan 26, 2015

@stefwalter yeah, that sounds like a good idea!

@petervo

This comment has been minimized.

Copy link
Contributor Author

commented Jan 26, 2015

Design decision changed, will open a new PR that implements the new design decision.

@petervo petervo closed this Jan 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.