sosreport: Use "-v" instead of "-vvv" for verbose logging #17571
Conversation
mvollmer
force-pushed
the
sosreport-less-verbose
branch
from
44b4461
to
debe040
Compare
test/verify/check-sosreport
Outdated
| @@ -71,6 +71,7 @@ only-plugins=release,date,host,cgroups,networking | |||
| b.set_input_text("#sos-dialog .pf-c-form__group:contains(Report label) input", "mylabel") | |||
| b.set_input_text("#sos-dialog .pf-c-form__group:contains(Encryption passphrase) input", "foobar") | |||
| b.set_checked("#sos-dialog .pf-c-check:contains(Obfuscate) input", True) | |||
| b.set_checked("#sos-dialog .pf-c-check:contains(Use verbose logging) input", True) | |||
There was a problem hiding this comment.
Let's please test the default as well, not only verbose mode.
|
Enabling the verbose option in the basic test broke pixels as well. Let's just do another sos run with verbosity and without a pixel test, and ensure that the tarball has debug messages? |
mvollmer
force-pushed
the
sosreport-less-verbose
branch
from
debe040
to
4317f62
Compare
Plus some failures |
Using "-vvv" will write DEBUG messages to stdout which will all get trasmitted to the browser and then mostly ignored there. With "-v", DEBUG messages will still end up in the archive, but stdout will only receive WARNING messages, as normal. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2107667
mvollmer
force-pushed
the
sosreport-less-verbose
branch
from
4317f62
to
bc856dc
Compare
|
|
||
| # There should be one archive and it should contain a bunch of debug messages | ||
| self.assertEqual(m.execute("ls -l /var/tmp/sosreport*mylabel*.tar.xz | wc -l").strip(), "1") | ||
| self.assertGreater(int(m.execute("tar --wildcards -xaOf /var/tmp/sosreport*mylabel*.tar.xz '*/sos_logs/sos.log' | grep -c 'DEBUG: \\[plugin:release\\]'")), 5) |
There was a problem hiding this comment.
OK like this, just for the future: you can use a Python raw string for that, i.e. r"DEBUG: \[".
|
kdump failure in C9S -- retrying, but this likely points out a recent regression. Not for this PR, but for my pilot radar. |
|
Meh, why is kdump and bonding broken on all TF tests all of a sudden!? |
|
Oh, your branch is behind 9 commits, I suppose that's why the TF tests look so sorry. They are quite alright in other current PRs. Ignoring for now, as this is RC. |
|
sos tests succeeded, the rest is due to cockpit-project/cockpituous#506. EOUTOFPATIENCE. |
Using "-vvv" will write DEBUG messages to stdout which will all get
trasmitted to the browser and then mostly ignored there. With "-v",
DEBUG messages will still end up in the archive, but stdout will only
receive WARNING messages, as normal.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2107667