selinux: Allow cockpit-session to write user's home #18173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pam_google_authenticator creates a new ~/.google_authenticator.TMPSUFFIX and renames it. https://bugzilla.redhat.com/show_bug.cgi?id=2157901
martinpitt
temporarily deployed
to
cockpit-dist
GitHub Actions
Inactive
jelly
approved these changes
Jan 13, 2023
|
@jelly : That's not possible for atomic replacement, it must be in the same directory. Otherwise $HOME and /tmp (or any other place) could be on different mounts, then you can't |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pam_google_authenticator creates a new ~/.google_authenticator.TMPSUFFIX and renames it.
https://bugzilla.redhat.com/show_bug.cgi?id=2157901
See https://bugzilla.redhat.com/show_bug.cgi?id=2157901#c6 for how I reproduced and tested this. We don't have the google-authenticator package on our images, and the OTP token computation also is quite complicated to automate.