Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No package aliases #1869

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
1 participant
@stefwalter
Copy link
Contributor

commented Mar 2, 2015

Remove the concept of package aliases. Having so many different ways to access the same file breaks several things ... and is in general an anti-pattern:

  • The AMD loader loads duplicate modules via different names, some of which fail when loaded together. Our custom AMD loader work arounds for this.
  • The browser caching breaks, and files get loaded multiple times unnecessarily.

In addition this is complexity that admins, developers need to learn. It's not transparent.

Lastly, the whole point of having multiple implementations of the same aliases is rather bogus. We no transparent way for one package implementing an alias to override another package with the same aliases. Instead we should use an /usr/share/cockpit/alternatives directory and symlinks to select the package currently in use. This fits in well with how distros manage alternatives. And this is something that @mvollmer suggested a while back.

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2015

Depends on #1861

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2015

  • We rename the base package to be base1
  • The systemd package installs to the server directory.
@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2015

This also simplifies how the manifests are loaded. The url to load the combined manifests just loads a JSON object with each package mapped to its manifest directly. Very simple and transparent.

@stefwalter stefwalter added the needswork label Mar 2, 2015

@stefwalter stefwalter force-pushed the stefwalter:no-aliases branch 2 times, most recently from e84fab9 to 1f1fca4 Mar 3, 2015

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Mar 3, 2015

@stefwalter stefwalter removed the needswork label Mar 3, 2015

@stefwalter stefwalter changed the title WIP: No package aliases No package aliases Mar 3, 2015

@stefwalter stefwalter force-pushed the stefwalter:no-aliases branch from 1f1fca4 to 301ba65 Mar 3, 2015

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Mar 3, 2015

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2015

Removed aliases from documentation.

stefwalter added some commits Feb 28, 2015

shell: Load linguas from shell manifest.json
Now that we can cache the manifests properly, we have more
liberty to add data like this in them
base: Remove the unused cockpit.packages API
In general folks should just use the manifests from their own
package or server. This can be done by loading ./manifest.json or
../manifests.json respectively.

In addition one can use AMD loading of module 'manifests' to load
the ../manifests.js data we put in place earlier.

@stefwalter stefwalter force-pushed the stefwalter:no-aliases branch from 301ba65 to 44db4a4 Mar 4, 2015

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Mar 4, 2015

@stefwalter stefwalter force-pushed the stefwalter:no-aliases branch from 44db4a4 to 12e07ce Mar 4, 2015

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Mar 4, 2015

@stefwalter stefwalter force-pushed the stefwalter:no-aliases branch from 12e07ce to cb9b664 Mar 4, 2015

@stefwalter stefwalter closed this in 08e05fa Mar 4, 2015

@stefwalter stefwalter deleted the stefwalter:no-aliases branch Mar 4, 2015

@andreasn andreasn referenced this pull request Mar 4, 2015

Closed

Subscriptions #1857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.