Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for RHEL 7 #2122

Closed
wants to merge 10 commits into from

Conversation

Projects
None yet
3 participants
@mvollmer
Copy link
Member

commented Apr 9, 2015

Followups:

  • Investigate and maybe file bug about NM disconnections
  • Use sudo with journalctl, maybe, and run check-services as "admin" again.
  • Get SELinux and pam.d/sshd corrected

@mvollmer mvollmer changed the title Fixes for RHEL 7 WIP - Fixes for RHEL 7 Apr 9, 2015

@mvollmer mvollmer force-pushed the mvollmer:test-fix-r7 branch 2 times, most recently from 2121cb1 to d01798f Apr 9, 2015

@mvollmer mvollmer changed the title WIP - Fixes for RHEL 7 Fixes for RHEL 7 Apr 10, 2015

@@ -76,6 +76,14 @@ class TestDashboard(MachineCase):
b.click('#dashboard_setup_next')
b.wait_popdown('dashboard_setup_server_dialog')

This comment has been minimized.

Copy link
@stefwalter

stefwalter Apr 10, 2015

Contributor

Should we merge #2126 instead of this?

This comment has been minimized.

Copy link
@mvollmer

mvollmer Apr 13, 2015

Author Member

I am not sure what this refers to.

This comment has been minimized.

Copy link
@stefwalter

stefwalter Apr 13, 2015

Contributor

Instead of configuring /etc/pam.d/sshd

This comment has been minimized.

Copy link
@stefwalter

stefwalter Apr 13, 2015

Contributor

Oh, and it's #2126

This comment has been minimized.

Copy link
@mvollmer

mvollmer Apr 13, 2015

Author Member

Yes, let's do that.

This comment has been minimized.

Copy link
@mvollmer

mvollmer Apr 13, 2015

Author Member

Done.

This comment has been minimized.

Copy link
@mvollmer

mvollmer Apr 13, 2015

Author Member

Done.

# after changing the config of the additional network
# interfaces.
#
# XXX - file bug

This comment has been minimized.

Copy link
@stefwalter

stefwalter Apr 10, 2015

Contributor

Sounds pretty wild. I guess lets file this bug before we merge this pull request.

This comment has been minimized.

Copy link
@mvollmer

mvollmer Apr 13, 2015

Author Member

Yes, true.

This comment has been minimized.

Copy link
@mvollmer

mvollmer Apr 14, 2015

Author Member

Done.

@@ -560,6 +560,10 @@ class TestStorage(MachineCase):
m = self.machine
b = self.browser

# HACK - https://bugzilla.redhat.com/show_bug.cgi?id=1187481

This comment has been minimized.

Copy link
@stefwalter

stefwalter Apr 10, 2015

Contributor

This bug needs to be cloned for RHEL 7. There should be a 'Clone' link in the bug above.

This comment has been minimized.

Copy link
@mvollmer

mvollmer Apr 13, 2015

Author Member

Done.

@mvollmer

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2015

Page error: TypeError: 'null' is not an object (evaluating 'e.split')

This is probably fixed by #2111.

@mvollmer mvollmer force-pushed the mvollmer:test-fix-r7 branch from ad958ff to 605b58e Apr 13, 2015

@@ -65,6 +65,10 @@ Description=Test Template for %I
ExecStart=/usr/bin/test-service %I
""")

# Only root can read the system.journal on RHEL 7.
if m.os == "rhel-7":
b.default_user = "root"

This comment has been minimized.

Copy link
@stefwalter

stefwalter Apr 13, 2015

Contributor

Is there a bug about this? Do you know why there is a difference of behavior from Fedora?

This comment has been minimized.

Copy link
@mvollmer

mvollmer Apr 14, 2015

Author Member

I don't know the reason. I'll file a bug.

This comment has been minimized.

Copy link
@mvollmer

mvollmer Apr 14, 2015

Author Member

https://bugzilla.redhat.com/show_bug.cgi?id=1211499:

Access list granting read access on /var/log/journal to members of wheel group is adjusted at package install time. In RHEL there is no /var/log/journal by default so after user creates it has to setup access list on directory manually.

We create /var/log/journal explicitly, but don't adjust the permissions, apparently. Too obvious...

@mvollmer mvollmer force-pushed the mvollmer:test-fix-r7 branch 6 times, most recently from 5d8d15b to b68d2cb Apr 14, 2015

mvollmer added some commits Apr 9, 2015

test: Use bigger filesystems for resizing.
40 Megs is just too small:

  resize2fs: No space left on device While checking for on-line resizing support
test: Also disable chronyd in journal test, don't just stop it.
Otherwise it will come back after the reboot and bite us.
selinux: Avoid conflict with core policy again.
The conflict prevents installing our policy 'everywhere', but that
didn't matter when the OS already had a good enough policy for
Cockpit, like on Fedora.

RHEL doesn't yet have such a policy, so we need to overwrite it with
ours.
test: Dont use -k option with gzip.
It's not supported everywhere and not needed when using -c.

@mvollmer mvollmer force-pushed the mvollmer:test-fix-r7 branch 3 times, most recently from 752673e to dd66f3f Apr 14, 2015

@mvollmer mvollmer force-pushed the mvollmer:test-fix-r7 branch from dd66f3f to 218f89d Apr 15, 2015

@stefwalter stefwalter removed the needswork label Apr 15, 2015

@dperpeet

This comment has been minimized.

Copy link
Member

commented Apr 15, 2015

I haven't tested it, but the code changes appear sane

@mvollmer mvollmer closed this in 170d7d6 Apr 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.