Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Patternfly and Bootstrap instead of jQuery Mobile. #223

Closed
wants to merge 8 commits into from

Conversation

@mvollmer
Copy link
Member

commented Feb 25, 2014

No description provided.

@cockpit-automation

This comment has been minimized.

Copy link

commented Feb 25, 2014

👍 (rebased to master, fedora-20 x86_64 passed)

@stefwalter

This comment has been minimized.

Copy link
Contributor

commented on 392d51f Feb 25, 2014

Why are we enabling G_MESSAGES_DEBUG at all in our systemd unit file? If certain messages need to be shown, then they should be g_info() not g_debug().

This comment has been minimized.

Copy link
Member Author

replied Feb 25, 2014

This is the unit file for the integration tests only. I wanted to capture debug output as well, since that makes debugging lost races easier after the fact. However, the very detailed output from cockpit-ws isn't that useful anymore. That stuff seems to work just fine.

This comment has been minimized.

Copy link
Contributor

replied Feb 26, 2014

Fair enough ... pushed.

@stefwalter

This comment has been minimized.

Copy link
Contributor

commented on src/web/README.patternfly in 1e0f735 Feb 25, 2014

This should probably go into HACKING.

This comment has been minimized.

Copy link
Member

replied Feb 25, 2014

Yep, agreed.

@stefwalter

This comment has been minimized.

Copy link
Contributor

commented on 1e0f735 Feb 25, 2014

This commit fails make distcheck and make dist :

[stef@stef cockpit-test]$ make distcheck
make  dist-bzip2 am__post_remove_distdir='@:'
make[1]: Entering directory `/data/src/cockpit-test'
make[1]: *** No rule to make target `src/web/lib/jquery.mobile.theme-1.3.0.css', needed by `distdir'.  Stop.
make[1]: Leaving directory `/data/src/cockpit-test'
make: *** [dist] Error 2

This comment has been minimized.

Copy link
Member

replied Feb 26, 2014

Fixed.

@stefwalter

This comment has been minimized.

Copy link
Contributor

commented on src/ws/jquery.min.js in 1e0f735 Feb 25, 2014

Current master does not use symlinks between src/web and src/ws. All output files are built into $builddir (or copied there if they need no building).

This comment has been minimized.

Copy link
Member

replied Feb 25, 2014

Removed.

@stefwalter

This comment has been minimized.

Copy link
Contributor

commented on 56fdbd0 Feb 25, 2014

Verified and merged into master.

@stefwalter

This comment has been minimized.

Copy link
Contributor

commented on 2e873f8 Feb 25, 2014

Verified and merged into master.

@stefwalter stefwalter added this to the Modular Webapp milestone Feb 26, 2014

@cockpit-automation

This comment has been minimized.

Copy link

commented Feb 26, 2014

👍 (rebased to master, fedora-20 x86_64 passed)

@stefwalter

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2014

Squashed and pushed to master.

@stefwalter stefwalter closed this Feb 26, 2014

@mvollmer mvollmer deleted the wip/patternfly branch Mar 5, 2014

marusak pushed a commit to marusak/cockpit that referenced this pull request Aug 28, 2019
Use only 1 * for /modules/list. Fixes cockpit-project#223
if we're listing all modules then use a single * wildcard.
According to the bug report this is a bit faster.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.