Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More interesting --clean testing. #2445

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@mvollmer
Copy link
Member

commented Jun 25, 2015

No description provided.

@mvollmer

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2015

Hm, we could flip around --no-save to --save, so that just --force is non-destructive.

@stefwalter

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2015

What is the reason to use --clean to affect selinux installation? Perhaps the 'why?' should go into the commit message?

@stefwalter stefwalter added the question label Jun 29, 2015

@mvollmer mvollmer added the needswork label Jun 29, 2015

@mvollmer mvollmer force-pushed the mvollmer:test-clean branch from 002a2a6 to e28ccc1 Jun 29, 2015

@mvollmer

This comment has been minimized.

Copy link
Member Author

commented Jun 29, 2015

Added some explanation.

@mvollmer mvollmer force-pushed the mvollmer:test-clean branch from e28ccc1 to d7b8539 Jun 29, 2015

mvollmer added some commits Jun 25, 2015

test: Extend meaning of "--clean" option.
The idea is that we test master with "--clean" to get better
information about how the development version of Cockpit would do if
released to a distribution.

Otherwise, testing master would just repeat the tests that have
already been done for the most recent pull request.  Some races might
have different winners, and we would catch commits on master that have
not been fully tested by accident, but right now testing master is
largely uninteresting.

* The "cockpit" flavored image is always created from scratch (but not
  saved).

* The development version of the selinux policy is not installed since
  for a real release, the policy is determined externally.

@mvollmer mvollmer force-pushed the mvollmer:test-clean branch from d7b8539 to c5a5c3c Jun 29, 2015

@mvollmer mvollmer closed this in f750ae1 Jun 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.