Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent browser navigation when clicking shell links #3285

Merged
merged 2 commits into from Aug 2, 2017

Conversation

@stefwalter
Copy link
Contributor

commented Dec 7, 2015

These should use pushState, and that doesn't seem to be taking
effect in internet explorer. Lets see if this helps.

@stefwalter stefwalter added the needswork label Dec 7, 2015

@stefwalter stefwalter force-pushed the stefwalter:prevent-ie-navigation branch from ceb16ae to eca4dad Dec 7, 2015

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Dec 7, 2015
shell: Prevent browser navigation when clicking shell links
These should use pushState, and that doesn't seem to be taking
effect in internet explorer. Lets see if this helps.

Closes cockpit-project#3285
@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2015

This doesn't fix the issue.

@stefwalter stefwalter force-pushed the stefwalter:prevent-ie-navigation branch from eca4dad to 7077270 Dec 22, 2015

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Dec 22, 2015
shell: Prevent browser navigation when clicking shell links
These should use pushState, and that doesn't seem to be taking
effect in internet explorer. Lets see if this helps.

Closes cockpit-project#3285

@stefwalter stefwalter self-assigned this Dec 1, 2016

@stefwalter stefwalter force-pushed the stefwalter:prevent-ie-navigation branch from 7077270 to 10018bf Aug 1, 2017

@stefwalter stefwalter changed the title WIP: Prevent browser navigation when clicking shell links Prevent browser navigation when clicking shell links Aug 1, 2017

@stefwalter stefwalter removed the needswork label Aug 1, 2017

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2017

The test failure without the fix:


# ----------------------------------------------------------------------
# selenium-navigate.py:NavigateTestSuite.testNavigateNoReload duration: 90s
#
03:42:04 ERROR| Screenshot(test) - Wrote: screenshottestNavigateNoReload.png
03:42:04 ERROR| 
03:42:04 ERROR| Reproduced traceback from: /usr/lib/python2.7/site-packages/avocado/core/test.py:376
03:42:04 ERROR| Traceback (most recent call last):
03:42:04 ERROR|   File "/tmp/avocado_tests/selenium-navigate.py", line 38, in testNavigateNoReload
03:42:04 ERROR|     self.wait_id('system_information_change_systime', cond=visible)
03:42:04 ERROR|   File "/tmp/avocado_tests/seleniumlib.py", line 217, in wait_id
03:42:04 ERROR|     return self.wait(By.ID, text=el, baseelement=baseelement, overridetry=overridetry, fatal=fatal, cond=cond, jscheck=jscheck)
03:42:04 ERROR|   File "/tmp/avocado_tests/seleniumlib.py", line 211, in wait
03:42:04 ERROR|     self.get_debug_logs()

shell: Fix Internet Explorer navigating on sidebar links
The sidebar and navigation menu in the shell should not cause
navigation. In Internet Explorer the whole page was being reloaded
which was dropping local state in open frames and causing a lot
of flicker.

Add a test for this case.

Closes #3285

@stefwalter stefwalter force-pushed the stefwalter:prevent-ie-navigation branch from 10018bf to dec52c4 Aug 1, 2017

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Aug 1, 2017
shell: Cleanup link handling for shell links
These are other places we should be consistent and stop all
navigation if we've handled the link.

Closes cockpit-project#3285
shell: Cleanup link handling for shell links
These are other places we should be consistent and stop all
navigation if we've handled the link.

Closes #3285

@stefwalter stefwalter force-pushed the stefwalter:prevent-ie-navigation branch from dec52c4 to cd9bcfd Aug 1, 2017

@stefwalter stefwalter removed their assignment Aug 2, 2017

@martinpitt martinpitt merged commit 64522a8 into cockpit-project:master Aug 2, 2017

15 of 16 checks passed

verify/ubuntu-stable Testing in progress [cockpit-tests-87hvr]
Details
avocado/fedora-24 Tests passed
Details
container/kubernetes Tests passed
Details
selenium/chrome Tests passed
Details
selenium/explorer Tests passed
Details
selenium/firefox Tests passed
Details
verify/centos-7 Tests passed
Details
verify/debian-stable Tests passed
Details
verify/debian-testing Tests passed
Details
verify/fedora-26 Tests passed
Details
verify/fedora-atomic Tests passed
Details
verify/fedora-i386 Tests passed
Details
verify/rhel-7 Tests passed
Details
verify/rhel-7-4 Tests passed
Details
verify/rhel-atomic Tests passed
Details
verify/ubuntu-1604 Tests passed
Details
martinpitt added a commit that referenced this pull request Aug 2, 2017
shell: Fix Internet Explorer navigating on sidebar links
The sidebar and navigation menu in the shell should not cause
navigation. In Internet Explorer the whole page was being reloaded
which was dropping local state in open frames and causing a lot
of flicker.

Add a test for this case.

Closes #3285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.