Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Split avocado into its own test suite #3380

Closed
wants to merge 3 commits into from

Conversation

@stefwalter
Copy link
Contributor

commented Dec 21, 2015

This splits avocado tests into its own test suite.

Remaining to be done:

  • Blocking on #3335 ... especially where we start using new Status API contexts
  • Actually run the code and make sure it works, cannot do this until above.
  • Use different test runs for Firefox vs. Chrome
  • Print out avocado results in their native format (if there is such a thing)

@stefwalter stefwalter self-assigned this Dec 21, 2015

@stefwalter stefwalter force-pushed the stefwalter:split-avocado branch 3 times, most recently from 7c7c029 to c7cece6 Dec 21, 2015

@dperpeet

This comment has been minimized.

Copy link
Member

commented Dec 21, 2015

Print out avocado results in their native format (if there is such a thing)

These are currently only downloaded in case of failure. You can take a look at the results directory here:

command="cat " + os.path.join(MachineCase.avocado_results_dir, "latest/results.json"),

@dperpeet dperpeet removed the blocked label Dec 21, 2015

@stefwalter stefwalter force-pushed the stefwalter:split-avocado branch from c7cece6 to 7313269 Dec 22, 2015

name = os.environ.get("TEST_NAME")
if not name:
name = "test"

if opts.publish:
sink = start_publishing(github, opts.publish, name, revision, image)

This comment has been minimized.

Copy link
@mvollmer

mvollmer Jan 13, 2016

Member

The '--publish' option should be removed as well.

@@ -19,71 +19,6 @@ EXCLUDE = [
'check-example'
]

def start_publishing(github, host, name, revision, image):

This comment has been minimized.

Copy link
@mvollmer

mvollmer Jan 13, 2016

Member

The github local variable in main can also be removed.

@mvollmer

This comment has been minimized.

Copy link
Member

commented Jan 13, 2016

I find check-verify --publish useful when working on support for a new OS, but that is a corner case and needs to be done carefully. Let's worry about this the next time we need it.

@stefwalter stefwalter force-pushed the stefwalter:split-avocado branch from 7313269 to 78b67df Jan 13, 2016


else:
sys.stderr.write("github-task: unknown context: " + context)
return 1

if opts.rebase:

This comment has been minimized.

Copy link
@mvollmer

mvollmer Jan 14, 2016

Member

--rebase needs to be added to argparser.

@mvollmer

This comment has been minimized.

Copy link
Member

commented Jan 14, 2016

Here are some fixes for github-task: mvollmer@4939331

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Jan 19, 2016

Half merged, half replaced by #3505

@stefwalter stefwalter closed this Jan 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.