Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict Content-Security-Policy for docker package #3951

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
2 participants
@stefwalter
Copy link
Contributor

commented Mar 8, 2016

Does what it says on the tin.

  • Add a fork of term.js that includes Content-Security-Policy support
  • Removes bootstrap-select usage from docker component.

@stefwalter stefwalter added the needswork label Mar 8, 2016

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2016

Needs a bit more work to get everything in place.

@stefwalter stefwalter force-pushed the stefwalter:docker-csp branch from 42b2f90 to 629e309 Mar 10, 2016

@stefwalter stefwalter removed the needswork label Mar 10, 2016

@stefwalter stefwalter force-pushed the stefwalter:docker-csp branch 2 times, most recently from 9117f3c to c0ef234 Mar 10, 2016

@stefwalter stefwalter changed the title WIP: Strict Content-Security-Policy for docker package Strict Content-Security-Policy for docker package Mar 10, 2016

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2016

Fixed tests.

@dperpeet

This comment has been minimized.

Copy link
Member

commented Mar 10, 2016

why does this remove the less license if the package stays in bower as a requirement?

@dperpeet dperpeet added the question label Mar 10, 2016

stefwalter added some commits Mar 10, 2016

base1: Use a forked version of term.js
We'll use a forked version of term.js for now. It includes the
following pull requests not yet merged upstream:

 * Support for Content-Security-Policy
   chjj/term.js#115

 * Define itself as an AMD module when running under AMD
   chjj/term.js#116

https://github.com/cockpit-project/term.js
docker: Strict Content-Security-Policy to docker package
This includes making term.js work as well as some other fixes.
docker: Remove use of bootstrap-select from docker package
Because it really integrates poorly with anything but hand
crafted HTML.

It also doesn't work with Content-Security-Policy

@stefwalter stefwalter removed the question label Mar 10, 2016

@stefwalter stefwalter force-pushed the stefwalter:docker-csp branch from c0ef234 to 6efd310 Mar 10, 2016

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2016

Added back less LICENSE which was accidentally removed.

@dperpeet dperpeet self-assigned this Mar 11, 2016

@dperpeet dperpeet closed this in c7536ec Mar 11, 2016

@stefwalter stefwalter deleted the stefwalter:docker-csp branch Mar 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.