New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added next run and last run time to timers display. #4503

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@harishanand95
Contributor

harishanand95 commented May 30, 2016

@dperpeet @petervo I need moment.js in this. i did like this selinux/moment to get moment as of now. Can u tell me how to add moment right way?
@andreasn can u look into designs here?
screenshot from 2016-05-30 16-41-55

also what should I do when it shows last run 46 years ago i.e 1970 ?

@petervo

This comment has been minimized.

Show comment
Hide comment
@petervo

petervo May 30, 2016

Contributor

You should rebase this on the latest master.

To use moment you should create a link in your directory to the moment.js file in bower_components and then change the makefile to include it in the bundle for this package. You can see an example of this in either the selinux, kubernetes or ostree package.

Contributor

petervo commented May 30, 2016

You should rebase this on the latest master.

To use moment you should create a link in your directory to the moment.js file in bower_components and then change the makefile to include it in the bundle for this package. You can see an example of this in either the selinux, kubernetes or ostree package.

@harishanand95

This comment has been minimized.

Show comment
Hide comment
@harishanand95

harishanand95 Jun 2, 2016

Contributor

@andreasn why does the disabled section has a different style than enabled and static ?

Contributor

harishanand95 commented Jun 2, 2016

@andreasn why does the disabled section has a different style than enabled and static ?

@andreasn

This comment has been minimized.

Show comment
Hide comment
@andreasn

andreasn Jun 2, 2016

Contributor

What do you mean more specifically?
That they don't have the "Previous Run" and "Next Run"? or that they are kind of centered in the middle of the table?

Contributor

andreasn commented Jun 2, 2016

What do you mean more specifically?
That they don't have the "Previous Run" and "Next Run"? or that they are kind of centered in the middle of the table?

@harishanand95

This comment has been minimized.

Show comment
Hide comment
@harishanand95

harishanand95 Jun 2, 2016

Contributor

@andreasn Previous run and next run is what I added extra. Is it okay? Is the repetition of the words next run and last run for each of entry good?
and yes I was actually talking about the id's being centered in the middle for disable? Why is that? I felt it would have been nice to have it like enabled and static.

Contributor

harishanand95 commented Jun 2, 2016

@andreasn Previous run and next run is what I added extra. Is it okay? Is the repetition of the words next run and last run for each of entry good?
and yes I was actually talking about the id's being centered in the middle for disable? Why is that? I felt it would have been nice to have it like enabled and static.

@harishanand95

This comment has been minimized.

Show comment
Hide comment
@harishanand95
Contributor

harishanand95 commented Jun 8, 2016

screenshot from 2016-06-06 15-01-31
screenshot from 2016-06-06 15-12-32

Show outdated Hide outdated pkg/systemd/Makefile.am Outdated
Show outdated Hide outdated pkg/systemd/init.js Outdated
Show outdated Hide outdated pkg/systemd/init.js Outdated
Show outdated Hide outdated pkg/systemd/init.js Outdated
Show outdated Hide outdated pkg/systemd/init.js Outdated
Show outdated Hide outdated pkg/systemd/init.js Outdated
Show outdated Hide outdated pkg/systemd/init.js Outdated
Show outdated Hide outdated pkg/systemd/services.html Outdated
@dperpeet

This comment has been minimized.

Show comment
Hide comment
@dperpeet

dperpeet Jun 16, 2016

Member

looks good, but there is still some work to be done

Member

dperpeet commented Jun 16, 2016

looks good, but there is still some work to be done

Show outdated Hide outdated pkg/systemd/init.js Outdated
Show outdated Hide outdated pkg/systemd/init.js Outdated
@harishanand95

This comment has been minimized.

Show comment
Hide comment
@harishanand95

harishanand95 Jun 16, 2016

Contributor

screenshot from 2016-06-16 23-10-17

@dperpeet I have changed next run time and last trigger time from relative time to calendar time-stamp.
Sorry abt the indentation and spaces

Contributor

harishanand95 commented Jun 16, 2016

screenshot from 2016-06-16 23-10-17

@dperpeet I have changed next run time and last trigger time from relative time to calendar time-stamp.
Sorry abt the indentation and spaces

Show outdated Hide outdated pkg/systemd/init.js Outdated
Show outdated Hide outdated pkg/systemd/init.js Outdated

@dperpeet dperpeet added question and removed needswork labels Jun 20, 2016

@dperpeet

This comment has been minimized.

Show comment
Hide comment
@dperpeet

dperpeet Jun 20, 2016

Member

I would suggest unknown instead of not known if there isn't a timestamp available, but either one is correct.

Member

dperpeet commented Jun 20, 2016

I would suggest unknown instead of not known if there isn't a timestamp available, but either one is correct.

@dperpeet

This comment has been minimized.

Show comment
Hide comment
@dperpeet

dperpeet Jun 20, 2016

Member

It would be great to add this to the integration tests - either in services or in a new one.

Member

dperpeet commented Jun 20, 2016

It would be great to add this to the integration tests - either in services or in a new one.

Show outdated Hide outdated test/verify/check-services Outdated

@andreasn andreasn self-assigned this Jun 22, 2016

@andreasn

This comment has been minimized.

Show comment
Hide comment
@andreasn

andreasn Jun 23, 2016

Contributor

the labels "Next Run Time" and "Last Trigger Time" sounds a bit off to me.
Could it be just "Next Run" and "Last Trigger" instead?
That it's times you'll be able to see from the fact that the labels are times and dates.

Contributor

andreasn commented Jun 23, 2016

the labels "Next Run Time" and "Last Trigger Time" sounds a bit off to me.
Could it be just "Next Run" and "Last Trigger" instead?
That it's times you'll be able to see from the fact that the labels are times and dates.

@harishanand95

This comment has been minimized.

Show comment
Hide comment
@harishanand95

harishanand95 Jun 23, 2016

Contributor

@andreasn removed "Time" from Next Run Time and Last Trigger Time and also added few deleted new lines that was already present in the code.
screenshot from 2016-06-23 17-43-11

Contributor

harishanand95 commented Jun 23, 2016

@andreasn removed "Time" from Next Run Time and Last Trigger Time and also added few deleted new lines that was already present in the code.
screenshot from 2016-06-23 17-43-11

@andreasn

This comment has been minimized.

Show comment
Hide comment
@andreasn

andreasn Jun 23, 2016

Contributor

Can current state be just "State"?

Contributor

andreasn commented Jun 23, 2016

Can current state be just "State"?

@harishanand95

This comment has been minimized.

Show comment
Hide comment
@harishanand95

harishanand95 Jun 23, 2016

Contributor

@andreasn Corrected
screenshot from 2016-06-23 18-19-49

Contributor

harishanand95 commented Jun 23, 2016

@andreasn Corrected
screenshot from 2016-06-23 18-19-49

@andreasn

This comment has been minimized.

Show comment
Hide comment
@andreasn

andreasn Jun 23, 2016

Contributor

Looks good to me.
Thanks for fixing this!

Contributor

andreasn commented Jun 23, 2016

Looks good to me.
Thanks for fixing this!

@dperpeet dperpeet removed the question label Jun 24, 2016

Show outdated Hide outdated test/verify/check-services Outdated

@dperpeet dperpeet added the needswork label Jun 27, 2016

@harishanand95 harishanand95 referenced this pull request Jun 28, 2016

Closed

systemd create timer option #4645

6 of 6 tasks complete

@dperpeet dperpeet removed the needswork label Jun 28, 2016

@dperpeet dperpeet assigned dperpeet and unassigned andreasn Jun 29, 2016

@dperpeet

This comment has been minimized.

Show comment
Hide comment
@dperpeet

dperpeet Jun 30, 2016

Member

There's a merge conflict - can you please rebase on master and squash the commits into one? Thanks!

Member

dperpeet commented Jun 30, 2016

There's a merge conflict - can you please rebase on master and squash the commits into one? Thanks!

@dperpeet

This comment has been minimized.

Show comment
Hide comment
@dperpeet

dperpeet Jun 30, 2016

Member

@andreasn Right now this code doesn't update the display, it only shows the time differences (e.g. "in 5 seconds") on load. I think this is ok for now. Do you agree?

Member

dperpeet commented Jun 30, 2016

@andreasn Right now this code doesn't update the display, it only shows the time differences (e.g. "in 5 seconds") on load. I think this is ok for now. Do you agree?

@dperpeet dperpeet added the needswork label Jun 30, 2016

@andreasn

This comment has been minimized.

Show comment
Hide comment
@andreasn

andreasn Jun 30, 2016

Contributor

@dperpeet yeah, I think it's all right for now, but I would like it to be fixed as a followup.

Contributor

andreasn commented Jun 30, 2016

@dperpeet yeah, I think it's all right for now, but I would like it to be fixed as a followup.

@dperpeet dperpeet removed the needswork label Jun 30, 2016

@dperpeet dperpeet closed this in bd9e8ae Jul 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment