New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call right tuned.disable() function when stopping tuned #4623

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@stefwalter
Contributor

stefwalter commented Jun 23, 2016

In addition disable the tuned service when the user has chosen
the "none" option. Enable the tuned service only when the user
has chosen an actual profile.

Add tests for this.

function set_service() {
/* When the profile is none we disable tuned */
var enable = (dialog_selected != "none");
var action = enable ? "start" : "stop";

This comment has been minimized.

@dperpeet

dperpeet Jun 24, 2016

Member

Above you use disable, here start or stop, is this intentional?

@dperpeet

dperpeet Jun 24, 2016

Member

Above you use disable, here start or stop, is this intentional?

This comment has been minimized.

@stefwalter

stefwalter Jun 24, 2016

Contributor

Yup. It's a pretty wild ride. But this is how we get to make tuned-adm active consistent with what the user expects.

@stefwalter

stefwalter Jun 24, 2016

Contributor

Yup. It's a pretty wild ride. But this is how we get to make tuned-adm active consistent with what the user expects.

@dperpeet dperpeet added the question label Jun 24, 2016

@stefwalter stefwalter removed the question label Jun 24, 2016

Show outdated Hide outdated pkg/tuned/dialog.js Outdated

@dperpeet dperpeet added the needswork label Jun 26, 2016

tuned: Call right tuned.disable() function when stopping tuned
In addition disable the tuned service when the user has chosen
the "none" option. Enable the tuned service only when the user
has chosen an actual profile.

Add tests for this.

@stefwalter stefwalter removed the needswork label Jun 27, 2016

@mvollmer mvollmer closed this in 0462c71 Jun 27, 2016

@stefwalter stefwalter deleted the stefwalter:tuned-disable-off branch Sep 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment