New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkmanager: Don't show unmanaged interfaces #4627

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@stefwalter
Contributor

stefwalter commented Jun 23, 2016

Don't show them in the Devices listing

@dperpeet

This comment has been minimized.

Show comment
Hide comment
@dperpeet

dperpeet Jun 23, 2016

Member

Why do we want to remove these from the listing?

Member

dperpeet commented Jun 23, 2016

Why do we want to remove these from the listing?

@dperpeet dperpeet added the question label Jun 23, 2016

@stefwalter

This comment has been minimized.

Show comment
Hide comment
@stefwalter

stefwalter Jun 24, 2016

Contributor

People mark interfaces with NM_CONTROLLED=no to take their life into ... no I mean ... tell NetworkManager to stop auto-configuring or involving itself in a given interface. The intent is that they want to configure this interface elsewhere (either via scripts, tools, or another daemon), without NetworkManager.

Since the current network interface is a UI for NetworkManager, we should respect those wishes.

This is a bug reported by people trying to use Cockpit on nodes where another network configuration service (vdsm) is in play:

https://bugzilla.redhat.com/show_bug.cgi?id=1330552

But the actual case is broader. NM_CONTROLLED=no is the way to tell NetworkManager "hands off".

Contributor

stefwalter commented Jun 24, 2016

People mark interfaces with NM_CONTROLLED=no to take their life into ... no I mean ... tell NetworkManager to stop auto-configuring or involving itself in a given interface. The intent is that they want to configure this interface elsewhere (either via scripts, tools, or another daemon), without NetworkManager.

Since the current network interface is a UI for NetworkManager, we should respect those wishes.

This is a bug reported by people trying to use Cockpit on nodes where another network configuration service (vdsm) is in play:

https://bugzilla.redhat.com/show_bug.cgi?id=1330552

But the actual case is broader. NM_CONTROLLED=no is the way to tell NetworkManager "hands off".

@stefwalter stefwalter removed the question label Jun 24, 2016

@stefwalter

This comment has been minimized.

Show comment
Hide comment
@stefwalter

stefwalter Jun 24, 2016

Contributor

Added link to the commit message. Also added a note to the feature-networkmanager documentation about NM_CONTROLLED=no.

Contributor

stefwalter commented Jun 24, 2016

Added link to the commit message. Also added a note to the feature-networkmanager documentation about NM_CONTROLLED=no.

@dperpeet

This comment has been minimized.

Show comment
Hide comment
@dperpeet

dperpeet Jun 24, 2016

Member

That makes sense! Adding the link is good.

Member

dperpeet commented Jun 24, 2016

That makes sense! Adding the link is good.

@dperpeet dperpeet self-assigned this Jun 24, 2016

@dperpeet dperpeet closed this in 62c1f02 Jun 24, 2016

@stefwalter stefwalter deleted the stefwalter:network-unmanaged branch Jun 24, 2016

@mvollmer

This comment has been minimized.

Show comment
Hide comment
@mvollmer

mvollmer Jun 27, 2016

Member

Also see #1308

Member

mvollmer commented Jun 27, 2016

Also see #1308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment