Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkmanager: Show unmanaged devices #5053

Closed

Conversation

Projects
None yet
1 participant
@mvollmer
Copy link
Member

commented Sep 14, 2016

But don't allow any changes

@mvollmer mvollmer added the needswork label Sep 14, 2016

networkmanager: Offer all managed devices as slaves
This was missed in "4ce54fd networkmanager: Show everything that is
managed".

@mvollmer mvollmer force-pushed the mvollmer:network-show-unmanaged branch from 2eca20f to 64e66cd Sep 15, 2016

@mvollmer mvollmer changed the title WIP - networkmanager: Show unmanaged devices networkmanager: Show unmanaged devices Sep 15, 2016

@mvollmer

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2016

Needs tests.

@mvollmer

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2016

The idea here is that hiding unmanaged interfaces is confusing. We can show that they exist and also show some of their state and their traffic.

if (parts.length > 0)
return $('<span>').text(parts.join(", "));
else
return _("Inactive");

This comment has been minimized.

Copy link
@mvollmer

mvollmer Sep 15, 2016

Author Member

This should only happen for unmanaged devices,

This comment has been minimized.

Copy link
@mvollmer

mvollmer Sep 15, 2016

Author Member

Done

@mvollmer mvollmer force-pushed the mvollmer:network-show-unmanaged branch from 64e66cd to 7069b90 Sep 15, 2016

networkmanager: Show unmanaged devices
in their own panel, except the uninteresting loopback device.  No
changes to unmanaged devices are allowed, even if people navgate to
them via the URL.

@mvollmer mvollmer force-pushed the mvollmer:network-show-unmanaged branch from 7069b90 to 9292468 Sep 15, 2016

@mvollmer

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2016

Needs tests.

Added a simple one.

@mvollmer mvollmer removed the needswork label Sep 15, 2016

@mvollmer

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2016

Test is failing on the Atomics and centos-7.

@mvollmer mvollmer added the needswork label Sep 19, 2016

networkmanager: Devices count as unmanaged unless we are told otherwise
Our fake object manager doesn't seem to pick up the o.f.NM.Device
interface properties for unmanaged devices with older versions of
NetworkManager.
@mvollmer

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2016

Test is failing on the Atomics and centos-7.

For unclear reasons, we didn't get the o.fd.NM.Device properties into the D-Bus cache, and the Managed property would default to true.

I am not sure wether this is worth debugging further: NM used to have a pretty idiosyncratic implementation of o.fd.DBUs.Properties, but they have changed over to GDBus recently, which should work better.

@mvollmer

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2016

and the Managed property would default to true.

So I have changed the default to false, with the assumption that we will never miss the properties of managed devices.

@mvollmer

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2016

I am not sure wether this is worth debugging further

Turning debugging on in cockpit-bridge makes the bug go away...

@mvollmer mvollmer removed the needswork label Sep 19, 2016

@dperpeet dperpeet closed this in 018ffcc Sep 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.