Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian 8 image and adapt tests #5324

Merged
merged 6 commits into from Nov 14, 2016

Conversation

Projects
None yet
3 participants
@stefwalter
Copy link
Contributor

commented Nov 8, 2016

  • Build images
  • Update control files
  • Add to testing cycle
  • Adapt tests
@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Nov 8, 2016

The question is whether we should disable automatic testing on 'debian-unstable' similar to 'fedora-testing'.

The only issue there would be related to tests like 'freeipa' which won't run on 'debian-8' but will run on 'debian-unstable'

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Nov 8, 2016

Blocked on #5323 and #5322 and #5318

@stefwalter stefwalter force-pushed the stefwalter:debian-8 branch 5 times, most recently from 12335ce to 1a01b96 Nov 8, 2016

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Nov 9, 2016

Need other handling of bad password during change:

Nov 09 00:55:19 unassigned-hostname cockpit-ws[1317]: cockpit-session: unable to change expired account or password: admin: Authentication token manipulation error
Nov 09 00:55:19 unassigned-hostname cockpit-ws[1317]: cockpit-session: Writing error pam-error
Nov 09 00:55:19 unassigned-hostname cockpit-ws[1317]: cockpit-session: Writing message Sorry, passwords do not match
Nov 09 00:55:19 unassigned-hostname cockpit-ws[1317]: cockpit-session: wrote result 20 to cockpit-ws

@stefwalter stefwalter force-pushed the stefwalter:debian-8 branch 2 times, most recently from 226c638 to 8807944 Nov 9, 2016

@stefwalter stefwalter removed the blocked label Nov 9, 2016

@stefwalter stefwalter force-pushed the stefwalter:debian-8 branch 2 times, most recently from 2ca3ae8 to d724f37 Nov 9, 2016

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Nov 9, 2016

This is ready to go. If #5325 gets merged first then this will need a rebase ... lets see.

@stefwalter stefwalter changed the title WIP: Add Debian 8 image and adapt tests Add Debian 8 image and adapt tests Nov 9, 2016

@stefwalter stefwalter force-pushed the stefwalter:debian-8 branch from d724f37 to 1738216 Nov 9, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 9, 2016

@stefwalter stefwalter force-pushed the stefwalter:debian-8 branch from 1738216 to 6956a4f Nov 9, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 9, 2016

@stefwalter stefwalter force-pushed the stefwalter:debian-8 branch from 6956a4f to bdcc348 Nov 9, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 9, 2016

@stefwalter stefwalter force-pushed the stefwalter:debian-8 branch from bdcc348 to 1a94f8a Nov 9, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 9, 2016

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Nov 9, 2016

Updated known issues.

@stefwalter stefwalter force-pushed the stefwalter:debian-8 branch from 1a94f8a to 3c5ce28 Nov 9, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 10, 2016

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Nov 10, 2016

Rebased.

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Nov 10, 2016

More work needed now that Debian networking stuff is merged.

@stefwalter stefwalter force-pushed the stefwalter:debian-8 branch from 1e93051 to 71a376d Nov 11, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 11, 2016

@stefwalter stefwalter removed the needswork label Nov 11, 2016

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Nov 11, 2016

Skipped relevant networking tests.

@stefwalter stefwalter force-pushed the stefwalter:debian-8 branch from 71a376d to 1d98010 Nov 11, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 11, 2016

@mvollmer

This comment has been minimized.

Copy link
Member

commented Nov 11, 2016

@stefwalter, this should fix check-networking basic: mvollmer@fdac3a0

@stefwalter stefwalter force-pushed the stefwalter:debian-8 branch from 1d98010 to 2820d6c Nov 11, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 11, 2016

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Nov 11, 2016

this should fix check-networking basic: mvollmer/cockpit@fdac3a0

Thanks. Squashed that in.

@dperpeet

This comment has been minimized.

Copy link
Member

commented Nov 14, 2016

needs rebase

stefwalter added some commits Nov 8, 2016

users: Handle older ssh-keygen output
In both the tests and the authorized-keys listing code, we need
to handle ssh-keygen output where the comment is not included in
the output of:

  $ ssh-keygen -l -f authorized_keys
ws: Retry changing expired passwords on PAM_AUTHTOK_ERR
On Debian the conversation doesn't automatically continue
when the user types an invalid new password. We offer to
restart the conversation three times.
lib: Fix undefined column value for listing
The docker view sometimes has undefined values depending
on the syntax of the JSON.

Fixes the error:

TypeError: undefined is not a valid argument for 'in' (evaluating ''header' in itm')
docker: Be compatible with older docker container Status fields
Older versions of the docker API don't have a container.State.Status
field, and it needs to be calculated from the other fields.

@stefwalter stefwalter removed the needswork label Nov 14, 2016

@stefwalter stefwalter force-pushed the stefwalter:debian-8 branch from 2820d6c to 782221b Nov 14, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 14, 2016

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2016

Rebased.

@stefwalter stefwalter force-pushed the stefwalter:debian-8 branch from 782221b to 041a813 Nov 14, 2016

@dperpeet dperpeet merged commit 98f29ac into cockpit-project:master Nov 14, 2016

12 checks passed

avocado/fedora-24 Tests passed
Details
container/kubernetes Tests passed
Details
selenium/chrome Tests passed
Details
selenium/firefox Tests passed
Details
semaphoreci The build passed on Semaphore.
Details
verify/centos-7 Tests passed
Details
verify/debian-unstable Tests passed
Details
verify/fedora-25 Tests passed
Details
verify/fedora-atomic Tests passed
Details
verify/rhel-7 Tests passed
Details
verify/rhel-atomic Tests passed
Details
verify/ubuntu-1604 Tests passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.