Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

po: Make our po files and extraction compatible with angular-gettext #5420

Closed

Conversation

Projects
None yet
2 participants
@stefwalter
Copy link
Contributor

commented Nov 17, 2016

Support extracting the getString() and getPlural() style of javascript strings. Also in our po files support loading into angular-gettext.

Use angular-gettext in the ostree component. And mark everything for transtlation appropriately.

Depends on:

@stefwalter stefwalter added the blocked label Nov 17, 2016

@stefwalter stefwalter force-pushed the stefwalter:translate-angular branch from 77e07bb to ebea24b Nov 17, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 17, 2016

@stefwalter stefwalter force-pushed the stefwalter:translate-angular branch from ebea24b to fd1a63e Nov 17, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 17, 2016

po: Make our po files and extraction compatible with angular-gettext
Support extracting the getString() and getPlural() style of markup.
Also in our po files support loading into angular-gettext.

Closes cockpit-project#5420

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 17, 2016

@stefwalter stefwalter force-pushed the stefwalter:translate-angular branch from fd1a63e to 63ae087 Nov 17, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 17, 2016

po: Make our po files and extraction compatible with angular-gettext
Support extracting the getString() and getPlural() style of markup.
Also in our po files support loading into angular-gettext.

Closes cockpit-project#5420

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 17, 2016

@stefwalter stefwalter force-pushed the stefwalter:translate-angular branch from 63ae087 to 04f6801 Nov 18, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 18, 2016

po: Make our po files and extraction compatible with angular-gettext
Support extracting the getString() and getPlural() style of markup.
Also in our po files support loading into angular-gettext.

Closes cockpit-project#5420

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 18, 2016

@stefwalter stefwalter force-pushed the stefwalter:translate-angular branch from 04f6801 to d7cc1d9 Nov 18, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 18, 2016

po: Make our po files and extraction compatible with angular-gettext
Support extracting the getString() and getPlural() style of markup.
Also in our po files support loading into angular-gettext.

Closes cockpit-project#5420

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 18, 2016

@stefwalter stefwalter force-pushed the stefwalter:translate-angular branch from d7cc1d9 to 899415c Nov 18, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 18, 2016

@petervo petervo referenced this pull request Nov 18, 2016

Closed

po: Extract HTML trantslations properly #5418

1 of 1 task complete
@petervo

This comment has been minimized.

Copy link
Contributor

commented Nov 18, 2016

I get "gettextLocale is not available" errors on both ostree and the translation page. make clean and rerunning autogen didn't help.

@petervo petervo added question and removed blocked labels Nov 18, 2016

stefwalter added some commits Nov 17, 2016

po: Extract HTML translations properly
This now supports most angular-gettext extractions. We support
extracting title translations, as well as prefering the newer
form HTML translate attributes.

This implements support in cockpit.translate().

The playground translate page has been updated to clearly denote
what forms of translate syntax are supported and where.

The tests have been updated both unit tests and integration test.

Closes #5418
po: Make our po files and extraction compatible with angular-gettext
Support extracting the getString() and getPlural() style of markup.
Also in our po files support loading into angular-gettext.

Closes #5420
ostree: Use angular-gettext in the ostree component
And mark everything for transtlation appropriately.

@stefwalter stefwalter force-pushed the stefwalter:translate-angular branch from 899415c to ecacd1f Nov 18, 2016

@stefwalter stefwalter removed the question label Nov 18, 2016

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Nov 18, 2016

I get "gettextLocale is not available" errors on both ostree and the translation page. make clean and rerunning autogen didn't help.

I hope this fixes the error. It's simpler too.

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 18, 2016

po: Make our po files and extraction compatible with angular-gettext
Support extracting the getString() and getPlural() style of markup.
Also in our po files support loading into angular-gettext.

Closes cockpit-project#5420

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Nov 18, 2016

@petervo petervo closed this in 07ab238 Nov 18, 2016

petervo added a commit that referenced this pull request Nov 18, 2016

test: Start testing angular translations
Closes #5420
Reviewed-by: Peter <petervo@redhat.com>

@stefwalter stefwalter deleted the stefwalter:translate-angular branch Jan 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.