Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ostree signatures #5433

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@petervo
Copy link
Contributor

commented Nov 18, 2016

No description provided.

@petervo petervo force-pushed the petervo:ostree-signatures branch 2 times, most recently from 3c944f7 to 79acdcf Nov 18, 2016

@stefwalter
Copy link
Contributor

left a comment

Code looks good. Just one request. Could you also paste a link to the design in the pull request?

if (!signature.v)
return;

var by = signature.v[11];

This comment has been minimized.

Copy link
@stefwalter

stefwalter Nov 19, 2016

Contributor

We should have a multiline comment here, either with a paste of the variant signature, but preferrably to the place where it's defined ... if possible a link to documentation.

This comment has been minimized.

Copy link
@petervo

petervo Nov 19, 2016

Author Contributor

Unfortunately this is not documented, and internal to the ostree library. The dbus variant type is a very opaque av. I can see what our options are on the dbus side, but since this hasn't changed since it was initially implemented I figured we'd use what we have and hopefully get something more stable in later iterations.

This comment has been minimized.

Copy link
@stefwalter

stefwalter Nov 19, 2016

Contributor

So lets add a comment about what the various numbers in that av are.

This comment has been minimized.

Copy link
@petervo

petervo Nov 19, 2016

Author Contributor

Added

@petervo

This comment has been minimized.

@petervo petervo force-pushed the petervo:ostree-signatures branch from 79acdcf to c8ffc8f Nov 19, 2016

@petervo petervo force-pushed the petervo:ostree-signatures branch from c8ffc8f to 73e1d13 Nov 19, 2016

@petervo petervo deleted the petervo:ostree-signatures branch Nov 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.