Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws: Make critical errors fatal when cockpit-tests is installed #5924

Closed

Conversation

Projects
None yet
3 participants
@stefwalter
Copy link
Contributor

commented Feb 22, 2017

When cockpit-tests are installed we make g_critical() style errors and preconditions fatal. This allows us to get backtraces for them. This continues the move in the direction of having installable tests located in cockpit-tests.

stefwalter added some commits Feb 7, 2017

Rename cockpit-test-assets package to cockpit-tests
We should start creating installable tests. This gets ready for that
with a well named package, that can include installable unit tests
and integration tests including (ideally) depending on the right
packages needed to run the tests.

Closes #5860
ws: Make critical errors fatal when cockpit-tests is installed
When cockpit-tests are installed we make g_critical() style errors
and preconditions fatal.  This allows us to get backtraces for them.

This continues the move in the direction of having installable tests
located in cockpit-tests.

@stefwalter stefwalter added the blocked label Feb 22, 2017

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2017

Tested with ./testsuite-prepare && ./check-login -tvs and

diff --git a/src/bridge/cockpitpolkitagent.c b/src/bridge/cockpitpolkitagent.c
index f08a346..9b595b4 100644
--- a/src/bridge/cockpitpolkitagent.c
+++ b/src/bridge/cockpitpolkitagent.c
@@ -504,6 +504,7 @@ cockpit_polkit_agent_register (CockpitTransport *transport,
   string = polkit_subject_to_string (subject);
 
   g_debug ("registered polkit authentication agent for subject: %s", string);
+  g_critical ("critical booo");
   g_free (string);
 
 out:

@stefwalter stefwalter referenced this pull request Feb 22, 2017

Closed

Pluggable message router in the bridge #5683

5 of 5 tasks complete

@petervo petervo closed this in 6dcb68e Feb 23, 2017

@petervo petervo removed the blocked label Feb 23, 2017

@martinpitt

This comment has been minimized.

Copy link
Member

commented Feb 23, 2017

This caused a build failure for RPMs: https://kojipkgs.fedoraproject.org//work/tasks/8393/18018393/build.log

error: Installed (but unpackaged) file(s) found:
   /etc/systemd/system/cockpit.service.d/fatal.conf

It's probably unrelated (unless you have to mark config files as such somehow), but I'd strongly recommend to put that file into /usr/lib/systemd/, not /etc.

@martinpitt

This comment has been minimized.

Copy link
Member

commented Feb 23, 2017

My first guess is that koji does not build the test-assets package. The bug is in src/ws/Makefile-ws.am, this drop-in should not be installed via make install -- because then you would get this modification into a "real" cockpit installation. It should only be installed through make install-test-assets. I. e. we need to move this from systemdserviced_DATA to install-test-assets::

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.