Debian packaging updates #6288

Merged
merged 4 commits into from Apr 6, 2017

Conversation

Projects
None yet
2 participants
Member

martinpitt commented Apr 6, 2017

Cockpit was synced to Ubuntu now, and its autopkgtest fails. When I wrote it, I only tested this on Debian. Now fixed and tested on both.

cockpit-ws still ran as root, unlike wit the RPMs where it runs as unprivileged system user. Privilege reduction is rather important for security, so bring that in line with cockpit.spec.

The third commit lowers the cockpit-docker Recommends: for the "cockpit" metapackage. Right now, a failing apt-get install cockpit (due to failing installation of docker.io) gives a bad first impression, even though it's not really cockpit's fault. But docker.io has 8 (!) release-critical bugs in unstable and hasn't been in Debian testing for a fair while. On Ubuntu, docker.io is much less popular than in the Fedora/RH world (LXC/lxd is preferred there), and docker has a fair share of dependencies. So "Suggests:" sounds more appropriate to me, packaging UIs will offer it as extending functionality, but I don't see much reason to always install it by default everywhere.

martinpitt added some commits Apr 6, 2017

tools: Fix autopkgtest on Ubuntu
"useradd admin" failed because the admin group already exists. It's just
a legacy variant of "sudo" and not otherwise needed, so just nuke it for
the test.
tools: Run cockpit-ws unprivileged in Debian/Ubuntu
Drop the obsolete dh_fixperms override, as the group on cockpit-session
is wrong anyway (different gids during build and install). Replace with
a proper statoverride.

This brings Debian's ws packaging in line with cockpit.spec.

@martinpitt martinpitt added the bot label Apr 6, 2017

tools: Lower cockpit-docker Recommends to Suggests in Debian packaging
docker.io is in a rather sorry state in Debian unstable right now, and
not in testing at all. It's also not core functionality of Cockpit, and
on architectures other than amd64 it's almost useless, so pulling in all
of docker and its dependencies by default is too heavy.

Closes #6288

@martinpitt martinpitt added the priority label Apr 6, 2017

Member

martinpitt commented Apr 6, 2017

This is ready to go, and I'd like it in 138 so that I can upload a clean package to Debian/Ubuntu. Thus setting "priority" label to have it on the release laundry list.

tools: Enable dh-autoreconf in Debian build
We already build-depend it, it was just not enabled. Updating autotools
files is necessary to make build system patches actually effective, and
is best practice anyway for ensuring proper support on all supported
architectures.
Contributor

larskarlitski commented Apr 6, 2017

Yep, makes sense to me. Thanks!

@larskarlitski larskarlitski merged commit 3981888 into cockpit-project:master Apr 6, 2017

4 checks passed

semaphoreci The build passed on Semaphore.
Details
verify/debian-8 Tests passed
Details
verify/debian-testing Tests passed
Details
verify/ubuntu-1604 Tests passed
Details

larskarlitski added a commit that referenced this pull request Apr 6, 2017

tools: Lower cockpit-docker Recommends to Suggests in Debian packaging
docker.io is in a rather sorry state in Debian unstable right now, and
not in testing at all. It's also not core functionality of Cockpit, and
on architectures other than amd64 it's almost useless, so pulling in all
of docker and its dependencies by default is too heavy.

Closes #6288

@martinpitt martinpitt deleted the martinpitt:debian branch Apr 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment