New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machines: Don't swallow promise failures #7121

Merged
merged 1 commit into from Jun 28, 2017

Conversation

Projects
None yet
3 participants
@mvollmer
Member

mvollmer commented Jun 27, 2017

This makes it possible to use the promises returned by the asynchronous
actions.

This uses 'fail' instead of 'catch'. Also, intercept the getProvider
errors only and not errors from the actual action as well.

machines: Don't swallow promise failures
This makes it possible to use the promises returned by the asynchronous
actions.

This uses 'fail' instead of 'catch'.  Also, it intercepts the
getVirtProvider errors only and not errors from the actual method call
as well.

@mvollmer mvollmer requested a review from mareklibra Jun 27, 2017

@martinpitt

This is nice, thanks!

@martinpitt martinpitt merged commit 1e6dd9f into cockpit-project:master Jun 28, 2017

14 of 16 checks passed

verify/debian-stable 1 tests failed
Details
verify/rhel-7-4 Testing in progress [cockpit-tests-fsb28]
Details
avocado/fedora-24 Tests passed
Details
container/kubernetes Tests passed
Details
selenium/chrome Tests passed
Details
selenium/firefox Tests passed
Details
semaphoreci The build passed on Semaphore.
Details
verify/centos-7 Tests passed
Details
verify/debian-testing Tests passed
Details
verify/fedora-26 Tests passed
Details
verify/fedora-atomic Tests passed
Details
verify/fedora-i386 Tests passed
Details
verify/rhel-7 Tests passed
Details
verify/rhel-atomic Tests passed
Details
verify/ubuntu-1604 Tests passed
Details
verify/ubuntu-stable Tests passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment