Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machines: Providers for machines javascript use webpack linking #7128

Merged

Conversation

@stefwalter
Copy link
Contributor

commented Jun 28, 2017

Other providers that want to reuse the machines javascript will
use static webpack or browserify javascript linking to bring
that code into their component.

This means that there will be a completely different package for
each provider, and they may replace each other using the standard
manifest.json mechanisms.

This allows us to keep from committing to a spceific version
of the machines provider API. We instead publish an NPM module
each time the code changes, and other providers can pull versions
of that module that are compatible with their code.

@stefwalter stefwalter force-pushed the stefwalter:static-linking-machines-provider branch from 08ee725 to 683ba52 Jun 28, 2017
@stefwalter stefwalter changed the title machines: Providers for machines javascript use webpack linking WIP machines: Providers for machines javascript use webpack linking Jun 28, 2017
@stefwalter stefwalter changed the title WIP machines: Providers for machines javascript use webpack linking machines: Providers for machines javascript use webpack linking Jun 28, 2017
Other providers that want to reuse the machines javascript will
use static webpack or browserify javascript linking to bring
that code into their component.

This means that there will be a completely different package for
each provider, and they may replace each other using the standard
manifest.json mechanisms.

This allows us to keep from committing to a spceific version
of the machines provider API. We instead publish an NPM module
each time the code changes, and other providers can pull versions
of that module that are compatible with their code.
@stefwalter stefwalter force-pushed the stefwalter:static-linking-machines-provider branch from 683ba52 to 462f4f3 Jun 29, 2017
@mareklibra mareklibra referenced this pull request Jun 29, 2017
14 of 14 tasks complete
@mvollmer mvollmer merged commit 8b6e18c into cockpit-project:master Jun 29, 2017
15 of 16 checks passed
15 of 16 checks passed
verify/fedora-i386 Not yet tested
Details
avocado/fedora-24 Tests passed
Details
container/kubernetes Tests passed
Details
selenium/chrome Tests passed
Details
selenium/firefox Tests passed
Details
semaphoreci The build passed on Semaphore.
Details
verify/centos-7 Tests passed
Details
verify/debian-stable Tests passed
Details
verify/debian-testing Tests passed
Details
verify/fedora-26 Tests passed
Details
verify/fedora-atomic Tests passed
Details
verify/rhel-7 Tests passed
Details
verify/rhel-7-4 Tests passed
Details
verify/rhel-atomic Tests passed
Details
verify/ubuntu-1604 Tests passed
Details
verify/ubuntu-stable Tests passed
Details
@stefwalter stefwalter deleted the stefwalter:static-linking-machines-provider branch Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.