New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small test cleanups #8051

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@martinpitt
Member

martinpitt commented Nov 9, 2017

This doesn't change much yet, but these are some common commits between my experimental electron+nightmare and chromium-headless branches which apply to our current tests as well.

Wrt. renaming phantom-lib.js: At some point we should rename its ph_*() functions to cockpit_test_*() or ct_*() or similar, as these have nothing to do specifically with Phantom. But this would be much more intrusive, and we can do that clarification later.

@martinpitt martinpitt added the bot label Nov 9, 2017

@cockpituous cockpituous changed the title from Small test cleanups to WIP: cockpit-tasks-ch43v: Small test cleanups Nov 9, 2017

@cockpituous cockpituous changed the title from WIP: cockpit-tasks-ch43v: Small test cleanups to Small test cleanups Nov 9, 2017

@martinpitt martinpitt added the needswork label Nov 9, 2017

@martinpitt martinpitt added blocked and removed needswork blocked labels Nov 9, 2017

@cockpituous cockpituous changed the title from Small test cleanups to WIP: cockpit-tasks-9bkd4: Small test cleanups Nov 10, 2017

@cockpituous cockpituous changed the title from WIP: cockpit-tasks-9bkd4: Small test cleanups to WIP: cockpit-tasks-37ghx: Small test cleanups Nov 10, 2017

@cockpituous cockpituous changed the title from WIP: cockpit-tasks-37ghx: Small test cleanups to WIP: cockpit-tasks-38r4x: Small test cleanups Nov 10, 2017

@cockpituous cockpituous changed the title from WIP: cockpit-tasks-38r4x: Small test cleanups to Small test cleanups Nov 10, 2017

@cockpituous cockpituous changed the title from Small test cleanups to WIP: cockpit-tasks-m4sjl: Small test cleanups Nov 10, 2017

@cockpituous cockpituous changed the title from WIP: cockpit-tasks-m4sjl: Small test cleanups to WIP: cockpit-tasks-s0z4j: Small test cleanups Nov 10, 2017

@cockpituous cockpituous changed the title from WIP: cockpit-tasks-s0z4j: Small test cleanups to Small test cleanups Nov 10, 2017

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Nov 12, 2017

@martinpitt martinpitt referenced this pull request Nov 12, 2017

Merged

test: Move from PhantomJS to Chrome Debug Protocol #8069

42 of 43 tasks complete

@cockpituous cockpituous changed the title from Small test cleanups to WIP: cockpit-tasks-x7tk6: Small test cleanups Nov 13, 2017

@cockpituous cockpituous changed the title from WIP: cockpit-tasks-x7tk6: Small test cleanups to WIP: cockpit-tasks-v7ksh: Small test cleanups Nov 13, 2017

@cockpituous cockpituous changed the title from WIP: cockpit-tasks-v7ksh: Small test cleanups to Small test cleanups Nov 13, 2017

test: Drop unused Browser.inject_js()
This is not being used anywhere, and would be a bit difficult to port to
e. g. nightmare, where you can only inject files, not code. It's also
questionable as short-lived code can just equally well be run through
`eval_js()` and friends.

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Nov 13, 2017

@martinpitt martinpitt removed the bot label Nov 13, 2017

@cockpit-project cockpit-project deleted a comment from cockpituous Nov 13, 2017

@cockpit-project cockpit-project deleted a comment from cockpituous Nov 13, 2017

@cockpit-project cockpit-project deleted a comment from cockpituous Nov 13, 2017

@cockpit-project cockpit-project deleted a comment from cockpituous Nov 13, 2017

@cockpit-project cockpit-project deleted a comment from cockpituous Nov 13, 2017

@cockpit-project cockpit-project deleted a comment from cockpituous Nov 13, 2017

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Nov 13, 2017

test: Rename phantom-lib.js
This is a set of test helper functions which is completely independent
from PhantomJS, and apply to other test interfaces (such as
chromium-headless or nightmare) as well. Rename it to test-functions.js
to clarify its role.

Closes cockpit-project#8051

@cockpit-project cockpit-project deleted a comment from cockpituous Nov 13, 2017

@cockpit-project cockpit-project deleted a comment from cockpituous Nov 13, 2017

@cockpit-project cockpit-project deleted a comment from cockpituous Nov 13, 2017

@cockpit-project cockpit-project deleted a comment from cockpituous Nov 13, 2017

@cockpit-project cockpit-project deleted a comment from cockpituous Nov 13, 2017

@cockpit-project cockpit-project deleted a comment from cockpituous Nov 13, 2017

@martinpitt

This comment has been minimized.

Show comment
Hide comment
@martinpitt

martinpitt Nov 13, 2017

Member

I just realized that phantomjs is required on the fedora-25 image for the avocado tests. I dropped that commit, and cleaned up all the related image refresh comments.

Member

martinpitt commented Nov 13, 2017

I just realized that phantomjs is required on the fedora-25 image for the avocado tests. I dropped that commit, and cleaned up all the related image refresh comments.

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Nov 13, 2017

test: Rename phantom-lib.js
This is a set of test helper functions which is completely independent
from PhantomJS, and apply to other test interfaces (such as
chromium-headless or nightmare) as well. Rename it to test-functions.js
to clarify its role.

Closes cockpit-project#8051
test: Rename phantom-lib.js
This is a set of test helper functions which is completely independent
from PhantomJS, and apply to other test interfaces (such as
chromium-headless or nightmare) as well. Rename it to test-functions.js
to clarify its role.

Closes #8051
@petervo

This comment has been minimized.

Show comment
Hide comment
@petervo

petervo Nov 13, 2017

Contributor

Renaming seems premature. I'm ok with removing the unused function though.

Contributor

petervo commented Nov 13, 2017

Renaming seems premature. I'm ok with removing the unused function though.

@martinpitt

This comment has been minimized.

Show comment
Hide comment
@martinpitt

martinpitt Nov 13, 2017

Member

OOI, why premature? Anyway, this isn't very important, it was mostly a check that nothing else depends on the old name. I'm fine with folding this into #8069 if you prefer.

Member

martinpitt commented Nov 13, 2017

OOI, why premature? Anyway, this isn't very important, it was mostly a check that nothing else depends on the old name. I'm fine with folding this into #8069 if you prefer.

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Nov 13, 2017

test: Rename phantom-lib.js
This is a set of test helper functions which is completely independent
from PhantomJS, and apply to other test interfaces (such as
chromium-headless or nightmare) as well. Rename it to test-functions.js
to clarify its role.

Closes cockpit-project#8051

@petervo petervo closed this in b240577 Nov 14, 2017

@petervo

This comment has been minimized.

Show comment
Hide comment
@petervo

petervo Nov 14, 2017

Contributor

Yeah, lets fold 6aba503 into #8069

Contributor

petervo commented Nov 14, 2017

Yeah, lets fold 6aba503 into #8069

@martinpitt martinpitt deleted the martinpitt:test-cleanups branch Nov 14, 2017

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Nov 15, 2017

test: Rename phantom-lib.js
This is a set of test helper functions which is completely independent
from PhantomJS, and apply to other test interfaces (such as
chromium-headless or nightmare) as well. Rename it to test-functions.js
to clarify its role.

Closes cockpit-project#8051

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Nov 15, 2017

test: Rename phantom-lib.js
This is a set of test helper functions which is completely independent
from PhantomJS, and apply to other test interfaces (such as
chromium-headless or nightmare) as well. Rename it to test-functions.js
to clarify its role.

Closes cockpit-project#8051

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Nov 16, 2017

test: Rename phantom-lib.js
This is a set of test helper functions which is completely independent
from PhantomJS, and apply to other test interfaces (such as
chromium-headless or nightmare) as well. Rename it to test-functions.js
to clarify its role.

Closes cockpit-project#8051

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Nov 17, 2017

test: Rename phantom-lib.js
This is a set of test helper functions which is completely independent
from PhantomJS, and apply to other test interfaces (such as
chromium-headless or nightmare) as well. Rename it to test-functions.js
to clarify its role.

Closes cockpit-project#8051

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Nov 19, 2017

test: Rename phantom-lib.js
This is a set of test helper functions which is completely independent
from PhantomJS, and apply to other test interfaces (such as
chromium-headless or nightmare) as well. Rename it to test-functions.js
to clarify its role.

Closes cockpit-project#8051

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Nov 20, 2017

test: Rename phantom-lib.js
This is a set of test helper functions which is completely unrelated to
PhantomJS, and apply to other test interfaces (such as chromium-headless
or electron) as well. Rename it to test-functions.js to clarify its
role.

Closes cockpit-project#8051

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Nov 21, 2017

test: Rename phantom-lib.js
This is a set of test helper functions which is completely unrelated to
PhantomJS, and apply to other test interfaces (such as chromium-headless
or electron) as well. Rename it to test-functions.js to clarify its
role.

Closes cockpit-project#8051

sabbaka added a commit to sabbaka/cockpit that referenced this pull request Jan 12, 2018

test: Drop unused Browser.inject_js()
This is not being used anywhere, and would be a bit difficult to port to
e. g. nightmare, where you can only inject files, not code. It's also
questionable as short-lived code can just equally well be run through
`eval_js()` and friends.

Closes cockpit-project#8051
Reviewed-by: Peter <petervo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment