New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small test fixes #8166

Merged
merged 4 commits into from Nov 28, 2017

Conversation

Projects
None yet
3 participants
@martinpitt
Member

martinpitt commented Nov 26, 2017

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Nov 26, 2017

test: Fix logout in check-reauthorize
Actually call Browser.logout().

Closes cockpit-project#8166

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Nov 27, 2017

test: Fix logout in check-reauthorize
Actually call Browser.logout().

Closes cockpit-project#8166

@martinpitt martinpitt referenced this pull request Nov 27, 2017

Merged

test: Move from PhantomJS to Chrome Debug Protocol #8069

42 of 43 tasks complete

martinpitt added some commits Nov 24, 2017

test: Fix race condition and ignore non-breaking spaces in check-term…
…inal

After sending "clear<CR>" we first need to wait for the screen to be
actually cleared (i. e. the first line stops containing the "clear"
command) before waiting for the prompt. Otherwise the expected prompt
can end up being `admin@localhost ~]$ clear`.

In chromium the terminal widget text lines contain a lot of trailing
non-breaking spaces (\xa0). Strip them off as they are not relevant and
confuse the subsequent text matching.
test: Fix logout in check-reauthorize
Actually call Browser.logout().

Closes #8166
test: Fix race in check-openshift
Commit 049778a added a test case for importing only selected tags from
a stream, which is still broken.

Commit 770bd4a changed the UI part of the test to assume the bug was
fixed (but not the CLI part), which only happens to work most of the
time in PhantomJS due to its slowness. In chromium the test reproduces
above bug all the time, so comment it out again and put back the EXFAIL
comment.

@mvollmer mvollmer merged commit 8dbf2ac into cockpit-project:master Nov 28, 2017

18 checks passed

avocado/fedora Tests passed
Details
container/kubernetes Tests passed
Details
selenium/chrome Tests passed
Details
selenium/explorer Tests passed
Details
selenium/firefox Tests passed
Details
semaphoreci The build passed on Semaphore.
Details
verify/centos-7 Tests passed
Details
verify/debian-stable Tests passed
Details
verify/debian-testing Tests passed
Details
verify/fedora-27 Tests passed
Details
verify/fedora-atomic Tests passed
Details
verify/fedora-i386 Tests passed
Details
verify/rhel-7 Tests passed
Details
verify/rhel-7-4 Tests passed
Details
verify/rhel-7-5 Tests passed
Details
verify/rhel-atomic Tests passed
Details
verify/ubuntu-1604 Tests passed
Details
verify/ubuntu-stable Tests passed
Details

@martinpitt martinpitt deleted the martinpitt:test-fixes branch Nov 28, 2017

sabbaka added a commit to sabbaka/cockpit that referenced this pull request Jan 12, 2018

test: Fix logout in check-reauthorize
Actually call Browser.logout().

Closes cockpit-project#8166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment