New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixes #8227

Merged
merged 4 commits into from Dec 7, 2017

Conversation

Projects
None yet
2 participants
@martinpitt
Member

martinpitt commented Dec 7, 2017

Another batch of test fixes that caused regressions in #8069 but are applicable to PhantomJS too.

martinpitt added some commits Dec 1, 2017

test: Add missing expect_load() to check-ostree
After logging in we have a page load, wait for it properly.
test: Fix race condition in OpenShift testNodeNavigation
The test assumed that `#machine-troubleshoot` was immediately visible
after a failed login; but there is a "Connecting..." state in between
where the button is hidden:

```
      <h1>Connecting to the machine</h1>
      <p></p>
      <div class="blank-slate-pf-main-action">
        <button id="machine-reconnect" class="btn btn-primary btn-lg" style="display: none;">Reconnect</button>
        <button id="machine-troubleshoot" class="btn btn-primary btn-lg" style="display: none;">Troubleshoot</button>
      </div>
```

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Dec 7, 2017

bots: Allow prefixes in storaged regression naughty pattern
This matches on a console message. With the Chromium port there will be
a `> warning:` prefix to indicate the log level, which is useful to
have, and set it apart from other kinds of output.

Closes cockpit-project#8227

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Dec 7, 2017

test: Create PNG/HTML/journal artifacts on OpenShift container test f…
…ailure

This is similar to what the  verify tests to, and are a great aid in
debugging test regressions.

Closes cockpit-project#8227
@larskarlitski

Looks correct to me. Thanks!

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Dec 7, 2017

test: Create PNG/HTML/journal artifacts on OpenShift container test f…
…ailure

This is similar to what the  verify tests to, and are a great aid in
debugging test regressions.

Closes cockpit-project#8227

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Dec 7, 2017

test: Create PNG/HTML/journal artifacts on OpenShift container test f…
…ailure

This is similar to what the  verify tests to, and are a great aid in
debugging test regressions.

Closes cockpit-project#8227
@martinpitt

This comment has been minimized.

Show comment
Hide comment
@martinpitt

martinpitt Dec 7, 2017

Member

Dropped the bots: Allow prefixes ... commit again, this needs to happen differently in #8069. With PhantomJS the entire error message gets repeated in the traceback.

Member

martinpitt commented Dec 7, 2017

Dropped the bots: Allow prefixes ... commit again, this needs to happen differently in #8069. With PhantomJS the entire error message gets repeated in the traceback.

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Dec 7, 2017

test: Create PNG/HTML/journal artifacts on OpenShift container test f…
…ailure

This is similar to what the  verify tests to, and are a great aid in
debugging test regressions.

Closes cockpit-project#8227
@martinpitt

This comment has been minimized.

Show comment
Hide comment
@martinpitt

martinpitt Dec 7, 2017

Member

Thinko, that extra prefix is still there, just not the >. I put it back as it was.

Member

martinpitt commented Dec 7, 2017

Thinko, that extra prefix is still there, just not the >. I put it back as it was.

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Dec 7, 2017

bots: Allow prefixes in storaged regression naughty pattern
This matches on a console message. With the Chromium port there will be
a `> warning:` prefix to indicate the log level, which is useful to
have, and set it apart from other kinds of output.

Closes cockpit-project#8227

@martinpitt martinpitt referenced this pull request Dec 7, 2017

Merged

test: Move from PhantomJS to Chrome Debug Protocol #8069

42 of 43 tasks complete

martinpitt added some commits Dec 7, 2017

bots: Allow prefixes in storaged regression naughty pattern
This matches on a console message. With the Chromium port there will be
a `warning:` prefix to indicate the log level, which is useful to
have, and set it apart from other kinds of output.
test: Create PNG/HTML/journal artifacts on OpenShift container test f…
…ailure

This is similar to what the  verify tests to, and are a great aid in
debugging test regressions.

Closes #8227

@larskarlitski larskarlitski merged commit 1ed0275 into cockpit-project:master Dec 7, 2017

18 checks passed

avocado/fedora Tests passed
Details
container/kubernetes Tests passed
Details
selenium/chrome Tests passed
Details
selenium/explorer Tests passed
Details
selenium/firefox Tests passed
Details
semaphoreci The build passed on Semaphore.
Details
verify/centos-7 Tests passed
Details
verify/debian-stable Tests passed
Details
verify/debian-testing Tests passed
Details
verify/fedora-27 Tests passed
Details
verify/fedora-atomic Tests passed
Details
verify/fedora-i386 Tests passed
Details
verify/rhel-7 Tests passed
Details
verify/rhel-7-4 Tests passed
Details
verify/rhel-7-5 Tests passed
Details
verify/rhel-atomic Tests passed
Details
verify/ubuntu-1604 Tests passed
Details
verify/ubuntu-stable Tests passed
Details

@martinpitt martinpitt deleted the martinpitt:test-fixes branch Dec 7, 2017

sabbaka added a commit to sabbaka/cockpit that referenced this pull request Jan 12, 2018

test: Create PNG/HTML/journal artifacts on OpenShift container test f…
…ailure

This is similar to what the  verify tests to, and are a great aid in
debugging test regressions.

Closes cockpit-project#8227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment