New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up various PhantomJS hacks #8275

Merged
merged 5 commits into from Dec 18, 2017

Conversation

Projects
None yet
2 participants
@martinpitt
Member

martinpitt commented Dec 15, 2017

Now that the port to Chromium has landed, clean up the PhantomJS hacks that are only related to the integration tests (unit tests still need to be ported).

martinpitt added some commits Dec 14, 2017

test: Clean up and simplify key presses
Chromium does not use long key names like "Return", but we use
`type="char"` for everything. Drop the compatibility shim for rewriting
`Return` to `\r` and update tests to use `\r` directly.

As iterating over a string iterates over its characters, change
`key_press()` invocations to just pass a string with all desired
characters, for better readability.
Drop remaining phantom checkpoints
These are not being used any more by our test machinery with chromium,
so this is just dead code now.
bots: Drop PhantomJS crash retries from tests-policy
We don't currently expect something similar with Chromium.

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Dec 15, 2017

@martinpitt martinpitt referenced this pull request Dec 15, 2017

Merged

test: Move from PhantomJS to Chrome Debug Protocol #8069

42 of 43 tasks complete
@larskarlitski

Great stuff. Thanks!

@larskarlitski larskarlitski merged commit 761a17b into cockpit-project:master Dec 18, 2017

18 checks passed

avocado/fedora Tests passed
Details
container/kubernetes Tests passed
Details
selenium/chrome Tests passed
Details
selenium/explorer Tests passed
Details
selenium/firefox Tests passed
Details
semaphoreci The build passed on Semaphore.
Details
verify/centos-7 Tests passed
Details
verify/debian-stable Tests passed
Details
verify/debian-testing Tests passed
Details
verify/fedora-27 Tests passed
Details
verify/fedora-atomic Tests passed
Details
verify/fedora-i386 Tests passed
Details
verify/rhel-7 Tests passed
Details
verify/rhel-7-4 Tests passed
Details
verify/rhel-7-5 Tests passed
Details
verify/rhel-atomic Tests passed
Details
verify/ubuntu-1604 Tests passed
Details
verify/ubuntu-stable Tests passed
Details

@martinpitt martinpitt deleted the martinpitt:phantom-cleanups branch Dec 18, 2017

sabbaka added a commit to sabbaka/cockpit that referenced this pull request Jan 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment