networking: Add hack to kick new bonds etc to be fully awake #8769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a hackish workaround, and we should hear from the NM people what they think of this. |
mvollmer
force-pushed
the
networking-explicitly-activate-new-bonds
branch
from
973dd51
to
93f987f
Compare
There is no clear message yet: https://bugzilla.redhat.com/show_bug.cgi?id=1548265 I'll see if I can tie up the loose ends here and make this merge-able. |
mvollmer
force-pushed
the
networking-explicitly-activate-new-bonds
branch
2 times, most recently
from
4b73c33
to
dbbabf0
Compare
mvollmer
changed the title
mvollmer
changed the title
|
Okay, I added tests also for bridge and teams, which suffer from the same regression, and (hopefully) made the workaround work and not break anything. |
NetworkManager 1.8.2 has a regression here, so let's test this explicitly. testBondingMain also hits the regression, but because the active interface has "manual" ipv4 settings, and Cockpit copies those to the bond, the bond ends up looking okay although it doesn't really work. testBond also hits the regression, but because it has one inactive interface, the bond ends up being functional (with just one slave). Fixes cockpit-project#8735
mvollmer
force-pushed
the
networking-explicitly-activate-new-bonds
branch
from
dbbabf0
to
51d2429
Compare
|
Let's not merge this just yet, it's possible that NM wants to revert to the old behavior. |
|
There is a proposed test for NM, so I assume we don't need the workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is expected to fix the failures uncovered by the new testBondActive test in #8736. Those tests are included and extended here.