Skip to content
Branch: master
Find file Copy path
Find file Copy path
Fetching contributors…
Cannot retrieve contributors at this time
79 lines (69 sloc) 2.88 KB
// Copyright 2017 The Cockroach Authors.
// Use of this software is governed by the Business Source License
// included in the file licenses/BSL.txt.
// As of the Change Date specified in that file, in accordance with
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0, included in the file
// licenses/APL.txt.
package batcheval
import (
func init() {
RegisterCommand(roachpb.RefreshRange, DefaultDeclareKeys, RefreshRange)
// RefreshRange scans the key range specified by start key through end
// key, and returns an error on any keys written more recently than
// the txn's original timestamp and less recently than the txn's
// current timestamp.
func RefreshRange(
ctx context.Context, batch engine.ReadWriter, cArgs CommandArgs, resp roachpb.Response,
) (result.Result, error) {
args := cArgs.Args.(*roachpb.RefreshRangeRequest)
h := cArgs.Header
if h.Txn == nil {
return result.Result{}, errors.Errorf("no transaction specified to %s", args.Method())
// Iterate over values until we discover any value written at or after the
// original timestamp, but before or at the current timestamp. Note that we
// iterate inconsistently without using the txn. This reads only committed
// values and returns all intents, including those from the txn itself. Note
// that we include tombstones, which must be considered as updates on refresh.
log.VEventf(ctx, 2, "refresh %s @[%s-%s]", args.Span(), h.Txn.OrigTimestamp, h.Txn.Timestamp)
intents, err := engine.MVCCIterate(ctx, batch, args.Key, args.EndKey, h.Txn.Timestamp, engine.MVCCScanOptions{
Inconsistent: true,
Tombstones: true,
}, func(kv roachpb.KeyValue) (bool, error) {
// TODO(nvanbenschoten): This is pessimistic. We only need to check
// !ts.Less(h.Txn.PrevRefreshTimestamp)
// This could avoid failed refreshes due to requests performed after
// earlier refreshes (which read at the refresh ts) that already
// observed writes between the orig ts and the refresh ts.
if ts := kv.Value.Timestamp; !ts.Less(h.Txn.OrigTimestamp) {
return true, errors.Errorf("encountered recently written key %s @%s", kv.Key, ts)
return false, nil
if err != nil {
return result.Result{}, err
// Check if any intents which are not owned by this transaction were written
// at or beneath the refresh timestamp.
for _, i := range intents {
// Ignore our own intents.
if i.Txn.ID == h.Txn.ID {
// Return an error if an intent was written to the span.
return result.Result{}, errors.Errorf("encountered recently written intent %s @%s",
i.Span.Key, i.Txn.Timestamp)
return result.Result{}, nil
You can’t perform that action at this time.