From 2a4b64c70bb821779874fbaaee7ffde9694ad169 Mon Sep 17 00:00:00 2001
From: Xin Hao Zhang <xzhang@cockroachlabs.com>
Date: Mon, 5 Feb 2024 21:50:33 +0000
Subject: [PATCH] ui: take non-negative derivative of full scan chart

The full scan metric was previously being displayed as a count using a
downsampling max aggregation function. This commit changes the full
scans graph in the sql dashboard to show the non-negative derivative
of the metric since this chart is more useful when displayed as a rate.

Epic: none
Fixes: #118535

Release note (ui change): The `Full Table/Index Scans` chart in the sql
metrics dashboard now shows the non-negative derivative of the number of
full scans tracked.
---
 .../views/cluster/containers/nodeGraphs/dashboards/sql.tsx  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/sql.tsx b/pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/sql.tsx
index 3bc464c89a91..5626a46b01c0 100644
--- a/pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/sql.tsx
+++ b/pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/sql.tsx
@@ -196,17 +196,17 @@ export default function (props: GraphDashboardProps) {
       isKvGraph={false}
       sources={nodeSources}
       tenantSource={tenantSource}
-      tooltip={`The total number of full table/index scans ${tooltipSelection}.`}
+      tooltip={`The total number of full table/index scans per second ${tooltipSelection}.`}
       showMetricsInTooltip={true}
     >
-      <Axis label="full scans">
+      <Axis label="full scans per second">
         {_.map(nodeIDs, node => (
           <Metric
             key={node}
             name="cr.node.sql.full.scan.count"
             title={nodeDisplayName(nodeDisplayNameByID, node)}
             sources={[node]}
-            downsampleMax
+            nonNegativeRate
           />
         ))}
       </Axis>