Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
sql/parser: avoid float -> unsigned conversions
While investigating this, I discovered that our current `round` implementation is quite dubious, and does not rely on any referenced source material or any material that I could find. I also found that Postgres does not implement 2-ary `round` where the first argument is a float. The above is addressed by: - replacing `round(float)` with a transcription of Postgres' `rint`. - replacing `round(float, int)` with an implementation that round-trips through apd. This is likely much slower, but likely correct. Updates #14405.
- Loading branch information
Showing
4 changed files
with
151 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters