New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: remove decommissioned nodes from dropdown on time series page #23110

Closed
dianasaur323 opened this Issue Feb 26, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@dianasaur323
Copy link
Collaborator

dianasaur323 commented Feb 26, 2018

I decommissioned node 4:

image

But can still get to it from the admin UI drop down. Meanwhile, the node list is correct:

image

@dianasaur323 dianasaur323 added this to the 2.0 milestone Feb 26, 2018

@vilterp vilterp added this to Bugs - 2.0 Priority in Web UI Feb 27, 2018

@vilterp vilterp changed the title ui: remove decommissioned nodes from drop down ui: remove decommissioned nodes from dropdown on time series page Feb 28, 2018

@mrtracy mrtracy self-assigned this Mar 1, 2018

@mrtracy

This comment has been minimized.

Copy link
Contributor

mrtracy commented Mar 1, 2018

Keep in mind that the decommissioned node still existed at some point, and you can view historical data on the graphs page.

A possibly different solution I'll throw out: since we're appending the NodeID already, we can add a marker (e.g. "d") into the node ID, and sort them after all other nodes. So something like "137.197.195.129:26257 (d, n4)", and it appears at the end of that list.

Otherwise, yes, they can be removed from that dropdown.

@dianasaur323

This comment has been minimized.

Copy link
Collaborator

dianasaur323 commented Mar 2, 2018

Hmmm.. I see - good point. That being said, at some point, regardless of whether or not we label it as (d, n4), we should remove the node especially after the time frame is out. I also have a suspicion that the behavior isn't what we expect - I don't remember the exact specifics, but I seem to remember that right after I decommissioned the node, I was no longer able to view time series metrics (it just shows no data available), which indicates that it's possible that the minute a node is decommissioned, we stop showing the time series? I believe when @m-schneider made some fixes, she removed the time series or decommissioned nodes from the graphs, and this might be the reason for this behavior. In that context, if we can't see the historical time series of the decommissioned nodes anyway, maybe the path of lease resistance is to just remove them from the dropdown? Open to thoughts.

@couchand

This comment has been minimized.

Copy link
Collaborator

couchand commented Mar 5, 2018

The current behavior (as I understand it) is that we continue to show the time series for the decommissioned node until it rolls out of the time window. (I will go verify that now verified: this is how it works). It would be a reasonable extension of this to also remove the node from the dropdown selector at this point in time, though that's a nontrivial change unfortunately.

I also like the idea of annotating such nodes as decommissioned for as long as they are still visible, both in the dropdown as well as the details tooltip (though I think we should be more obvious than just a 'd' -- perhaps [decommissioned]?).

Just for reference, the changes @m-schneider made for this (#21476) never landed, as it seemed that (#22626) took care of the usability concern without breaking historical data.

@couchand couchand added this to Decomissioned Nodes in Admin UI Categories Mar 5, 2018

mrtracy added a commit to mrtracy/cockroach that referenced this issue Mar 8, 2018

ui: Remove Decommissioned nodes from Dropdown
Decommissioned nodes no longer appear in the "Select node" dropdown on
the metrics page. The nodes still appear in the nodes list, and data for
the nodes is still graphed, but they will no longer clutter the
dropdown.

In the case that a user needs to see this data explicitly,
decommissioned nodes still appear on the Custom Graph debug page as an
available source - in this dropdown, they now have "[decommissioned]"
appended to their display name and are sorted to the end of the
dropdown.

Fixes cockroachdb#23110

Release note (admin ui): Decommissioned nodes no longer appear in the
node selection dropdown on the Metrics page.

mrtracy added a commit to mrtracy/cockroach that referenced this issue Mar 12, 2018

ui: Remove Decommissioned nodes from Dropdown
Decommissioned nodes no longer appear in the "Select node" dropdown on
the metrics page. The nodes still appear in the nodes list, and data for
the nodes is still graphed, but they will no longer clutter the
dropdown.

In the case that a user needs to see this data explicitly,
decommissioned nodes still appear on the Custom Graph debug page as an
available source - in this dropdown, they now have "[decommissioned]"
appended to their display name and are sorted to the end of the
dropdown.

Fixes cockroachdb#23110

Release note (admin ui): Decommissioned nodes no longer appear in the
node selection dropdown on the Metrics page.

mrtracy added a commit to mrtracy/cockroach that referenced this issue Mar 12, 2018

ui: Remove Decommissioned nodes from Dropdown
Decommissioned nodes no longer appear in the "Select node" dropdown on
the metrics page. The nodes still appear in the nodes list, and data for
the nodes is still graphed, but they will no longer clutter the
dropdown.

In the case that a user needs to see this data explicitly,
decommissioned nodes still appear on the Custom Graph debug page as an
available source - in this dropdown, they now have "[decommissioned]"
appended to their display name and are sorted to the end of the
dropdown.

Fixes cockroachdb#23110

Release note (admin ui): Decommissioned nodes no longer appear in the
node selection dropdown on the Metrics page.

Web UI automation moved this from Bugs - 2.0 Priority to Closed - Done Mar 13, 2018

mrtracy added a commit to mrtracy/cockroach that referenced this issue Mar 13, 2018

ui: Remove Decommissioned nodes from Dropdown
Decommissioned nodes no longer appear in the "Select node" dropdown on
the metrics page. The nodes still appear in the nodes list, and data for
the nodes is still graphed, but they will no longer clutter the
dropdown.

In the case that a user needs to see this data explicitly,
decommissioned nodes still appear on the Custom Graph debug page as an
available source - in this dropdown, they now have "[decommissioned]"
appended to their display name and are sorted to the end of the
dropdown.

Fixes cockroachdb#23110

Release note (admin ui): Decommissioned nodes no longer appear in the
node selection dropdown on the Metrics page.

@vilterp vilterp removed this from Decomissioned Nodes in Admin UI Categories Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment