Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: only update computed columns that need updating #23523

Open
knz opened this issue Mar 7, 2018 · 2 comments

Comments

@knz
Copy link
Member

@knz knz commented Mar 7, 2018

When initializing execution for UPDATE, all the computed columns become a candidate for recomputation ( ProcessComputedColumns loads all computed columns) even though only the computed columns that depend on modified columns need to be re-computed.

This can be further optimized by using the dependency list and only selected computed columns that have a dependency on the modified columns.

cc @justinj

@knz knz added this to the 2.1 milestone Mar 7, 2018
@justinj

This comment has been minimized.

Copy link
Member

@justinj justinj commented Mar 7, 2018

Also worth considering for recomputing CHECK constraints, perhaps.

@knz

This comment has been minimized.

Copy link
Member Author

@knz knz commented Mar 7, 2018

for the check expressions there was a TODO in the code already. but you're right.

@jordanlewis jordanlewis modified the milestones: 2.1, 2.2 Aug 30, 2018
@petermattis petermattis removed this from the 2.2 milestone Oct 5, 2018
@jordanlewis jordanlewis removed this from Backlog in (DEPRECATED) SQL execution Oct 16, 2018
@knz knz moved this from Triage to Release items (2.2) in (DEPRECATED) SQL Front-end, Lang & Semantics Oct 23, 2018
@jordanlewis jordanlewis added this to Triage in SQL Execution Team Apr 23, 2019
@jordanlewis jordanlewis moved this from Triage to Backlog in SQL Execution Team Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.