Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add support for COMMENT ON INDEX #41316

Closed
jordanlewis opened this issue Oct 4, 2019 · 1 comment

Comments

@jordanlewis
Copy link
Member

@jordanlewis jordanlewis commented Oct 4, 2019

We did several other COMMENT syntaxes - this one seems still missing.

@hueypark interested? :)

@jordanlewis jordanlewis added this to Triage in SQL Execution Team via automation Oct 4, 2019
@hueypark

This comment has been minimized.

Copy link
Contributor

@hueypark hueypark commented Oct 4, 2019

@jordanlewis Thank you for letting me know. I'll be working next week. Can you assign me?

craig bot pushed a commit that referenced this issue Oct 18, 2019
41555: sql: support `COMMENT ON INDEX` r=jordanlewis a=hueypark

Informs #41316.

This patch introduces support for index comments.

The syntax to set or delete a comment is the same as postgres:
`COMMENT ON INDEX ... IS ...`. See:
https://www.postgresql.org/docs/10/static/sql-comment.html

Release note (sql change): CockroachDB now supports associating
comments to SQL index using PostgreSQL's `COMMENT ON INDEX`.
This comment can be checked with the `SHOW INDEXES FROM ... WITH COMMENT` command.

Co-authored-by: Jaewan Park <jaewan.huey.park@gmail.com>
@jordanlewis jordanlewis closed this Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.