Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For EXPERIMENTAL CHANGEFEED, make clear if row is deleted even on key_only envelope #42602

Open
cretz opened this issue Nov 20, 2019 · 3 comments
Open
Projects

Comments

@cretz
Copy link

@cretz cretz commented Nov 20, 2019

Per a forum post, when I use a normal envelope on an EXPERIMENTAL CHANGEFEED, I can use the absence of after to know it is a delete. But on a key_only envelope, I have no way to determine whether the record is a delete or not. Consider some approach to make whether it is a deletion visible.

@ricardocrdb ricardocrdb added this to To do in Support via automation Nov 20, 2019
@ricardocrdb ricardocrdb moved this from To do to Triaging in Support Nov 22, 2019
@ricardocrdb ricardocrdb added the A-cdc label Nov 22, 2019
@ricardocrdb

This comment has been minimized.

Copy link
Collaborator

@ricardocrdb ricardocrdb commented Nov 22, 2019

Hey @cretz

Thanks for creating the issue as requested. As the forum post from @danhhz requested, please include an example of how you would like it to look, and we can look into this further.

@cretz

This comment has been minimized.

Copy link
Author

@cretz cretz commented Nov 22, 2019

In the forum post I said:

I think a deleted boolean in the JSON would be fine.

Here's the example:

{ "deleted": true }
@ricardocrdb

This comment has been minimized.

Copy link
Collaborator

@ricardocrdb ricardocrdb commented Nov 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Support
  
Triaging
2 participants
You can’t perform that action at this time.